leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Replace print() calls with structured Python logging in analyzer.py, serp_api.py, and llm.py #787

New Issue
Closed
opened 2026-03-29 00:22:33 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-29 00:22:33 +00:00
Owner
Copy Link
Copy Source

Context

Several backend modules use print() for diagnostic output. This means log levels cannot be filtered, output format is inconsistent, and log aggregation tools (e.g., Loki, CloudWatch) cannot parse structured fields.

Roadmap reference: ROADMAP.md -- P2 Backend -- "Add structured logging"

What to do

  1. Add a logging configuration module (or extend config.py) that sets up a root logger with a configurable level (LOG_LEVEL env var, defaulting to INFO).
  2. In analyzer.py, serp_api.py, and llm.py, replace every print(...) call with the appropriate logging.getLogger(__name__).<level>(...) call.
  3. Use structured key-value pairs where relevant (e.g., logger.info("patent fetched", extra={"patent_id": pid})).
  4. Optionally configure a JSON formatter when LOG_FORMAT=json is set.

Acceptance criteria

  • No print() calls remain in the three target modules.
  • Running the API with LOG_LEVEL=DEBUG emits debug messages; LOG_LEVEL=WARNING suppresses info messages.
  • Existing tests still pass.
## Context Several backend modules use `print()` for diagnostic output. This means log levels cannot be filtered, output format is inconsistent, and log aggregation tools (e.g., Loki, CloudWatch) cannot parse structured fields. Roadmap reference: ROADMAP.md -- P2 Backend -- "Add structured logging" ## What to do 1. Add a logging configuration module (or extend `config.py`) that sets up a root logger with a configurable level (`LOG_LEVEL` env var, defaulting to `INFO`). 2. In `analyzer.py`, `serp_api.py`, and `llm.py`, replace every `print(...)` call with the appropriate `logging.getLogger(__name__).<level>(...)` call. 3. Use structured key-value pairs where relevant (e.g., `logger.info("patent fetched", extra={"patent_id": pid})`). 4. Optionally configure a JSON formatter when `LOG_FORMAT=json` is set. ## Acceptance criteria - No `print()` calls remain in the three target modules. - Running the API with `LOG_LEVEL=DEBUG` emits debug messages; `LOG_LEVEL=WARNING` suppresses info messages. - Existing tests still pass.
AI-Manager added the P2agent-readysmallrefactor labels 2026-03-29 00:22:33 +00:00
AI-Manager commented 2026-03-29 01:02:52 +00:00
Author
Owner
Copy Link
Copy Source

Triage: Assigned to @developer. Reason: P2 refactor, small - replace print with logging.

**Triage**: Assigned to @developer. Reason: P2 refactor, small - replace print with logging.
AI-Manager commented 2026-03-29 01:14:58 +00:00
Author
Owner
Copy Link
Copy Source

Already implemented -- closing.

All modules in the SPARC/ package use logging.getLogger(__name__) instead of print(). A codebase search for print() calls in SPARC/ returns zero results. Specifically: analyzer.py, serp_api.py, and llm.py all import logging and use logger.info(), logger.warning(), and logger.error(). The config.py module configures the logging level via the LOG_LEVEL environment variable.

No further work needed.

**Already implemented -- closing.** All modules in the `SPARC/` package use `logging.getLogger(__name__)` instead of `print()`. A codebase search for `print()` calls in `SPARC/` returns zero results. Specifically: `analyzer.py`, `serp_api.py`, and `llm.py` all import `logging` and use `logger.info()`, `logger.warning()`, and `logger.error()`. The `config.py` module configures the logging level via the `LOG_LEVEL` environment variable. No further work needed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready refactor small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#787
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?