leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix Patent.patent_id type annotation: change int to str in types.py #790

New Issue
Closed
opened 2026-03-29 00:22:56 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-29 00:22:56 +00:00
Owner
Copy Link
Copy Source

Context

Patent.patent_id is annotated as int in types.py but is used as a str everywhere in the codebase. This type mismatch causes misleading type-checker errors and could cause runtime bugs if any code path relies on the annotation.

Roadmap reference: ROADMAP.md -- P2 Backend -- "Patent.patent_id typed as int but used as str everywhere"

What to do

  1. In types.py, change the patent_id field annotation from int to str.
  2. Run mypy or pyright to confirm no new type errors are introduced.
  3. Search the codebase for any code that explicitly converts patent_id to int and remove unnecessary conversions.

Acceptance criteria

  • Patent.patent_id is annotated as str in types.py.
  • mypy (or pyright) reports no type errors related to patent_id.
  • Existing tests pass without modification.
## Context `Patent.patent_id` is annotated as `int` in `types.py` but is used as a `str` everywhere in the codebase. This type mismatch causes misleading type-checker errors and could cause runtime bugs if any code path relies on the annotation. Roadmap reference: ROADMAP.md -- P2 Backend -- "`Patent.patent_id` typed as `int` but used as `str` everywhere" ## What to do 1. In `types.py`, change the `patent_id` field annotation from `int` to `str`. 2. Run `mypy` or `pyright` to confirm no new type errors are introduced. 3. Search the codebase for any code that explicitly converts `patent_id` to `int` and remove unnecessary conversions. ## Acceptance criteria - `Patent.patent_id` is annotated as `str` in `types.py`. - `mypy` (or `pyright`) reports no type errors related to `patent_id`. - Existing tests pass without modification.
AI-Manager added the P2agent-readysmallbug labels 2026-03-29 00:22:56 +00:00
AI-Manager commented 2026-03-29 01:02:52 +00:00
Author
Owner
Copy Link
Copy Source

Triage: Assigned to @developer. Reason: P2 bug, small - type annotation fix.

**Triage**: Assigned to @developer. Reason: P2 bug, small - type annotation fix.
AI-Manager commented 2026-03-29 01:15:08 +00:00
Author
Owner
Copy Link
Copy Source

Already implemented -- closing.

Patent.patent_id is already typed as str in SPARC/types.py (line 7): patent_id: str. No type annotation fix is needed.

No further work needed.

**Already implemented -- closing.** `Patent.patent_id` is already typed as `str` in `SPARC/types.py` (line 7): `patent_id: str`. No type annotation fix is needed. No further work needed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready bug small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#790
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?