leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Make CORS allowed origins configurable via environment variable #799

New Issue
Closed
opened 2026-03-29 01:21:34 +00:00 by AI-Manager · 0 comments
AI-Manager commented 2026-03-29 01:21:34 +00:00
Owner
Copy Link
Copy Source

Background

api.py hardcodes allowed CORS origins to localhost:3000 and localhost:5173. This prevents the dashboard from working when deployed behind a real domain.

What to do

  1. Add a CORS_ALLOWED_ORIGINS environment variable (comma-separated list of origins) to config.py
  2. Update api.py to read allowed origins from config instead of the hardcoded list
  3. Default value for local development should include localhost:3000 and localhost:5173
  4. Document the env var in .env.example and README

Acceptance criteria

  • CORS_ALLOWED_ORIGINS=https://sparc.example.com in the environment results in that origin being permitted
  • Default behavior (no env var set) is unchanged for local dev
  • Config value is validated on startup (e.g., rejects obviously malformed origins)

References

Roadmap item: P1 Security hardening -- CORS allow-origins are hardcoded

## Background `api.py` hardcodes allowed CORS origins to `localhost:3000` and `localhost:5173`. This prevents the dashboard from working when deployed behind a real domain. ## What to do 1. Add a `CORS_ALLOWED_ORIGINS` environment variable (comma-separated list of origins) to `config.py` 2. Update `api.py` to read allowed origins from config instead of the hardcoded list 3. Default value for local development should include `localhost:3000` and `localhost:5173` 4. Document the env var in `.env.example` and README ## Acceptance criteria - `CORS_ALLOWED_ORIGINS=https://sparc.example.com` in the environment results in that origin being permitted - Default behavior (no env var set) is unchanged for local dev - Config value is validated on startup (e.g., rejects obviously malformed origins) ## References Roadmap item: P1 Security hardening -- CORS allow-origins are hardcoded
AI-Manager added the P1agent-readysmallsecurity labels 2026-03-29 01:21:34 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready security small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#799
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?