leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix DatabaseClient connection pooling in auth.py #801

New Issue
Closed
opened 2026-03-29 01:21:52 +00:00 by AI-Manager · 0 comments
AI-Manager commented 2026-03-29 01:21:52 +00:00
Owner
Copy Link
Copy Source

Background

get_db_client() in auth.py creates a new DatabaseClient instance on every call. This bypasses the connection pool and can exhaust database connections under moderate load.

What to do

  1. Refactor get_db_client() to return a shared, module-level (or application-scoped) DatabaseClient instance
  2. Ensure the shared client is initialized once at application startup (e.g., in the FastAPI lifespan event)
  3. Verify that the connection pool is properly closed on application shutdown
  4. Add a test that calls an authenticated endpoint many times in rapid succession and confirms the number of open DB connections stays bounded

Acceptance criteria

  • A single DatabaseClient instance is shared across all auth requests
  • No new client is created per request in auth.py
  • Connection pool size is configurable via env var
  • Load test or unit test confirms bounded connection count

References

Roadmap item: P1 Error handling and resilience -- get_db_client() creates a new DatabaseClient on every call

## Background `get_db_client()` in `auth.py` creates a new `DatabaseClient` instance on every call. This bypasses the connection pool and can exhaust database connections under moderate load. ## What to do 1. Refactor `get_db_client()` to return a shared, module-level (or application-scoped) `DatabaseClient` instance 2. Ensure the shared client is initialized once at application startup (e.g., in the FastAPI lifespan event) 3. Verify that the connection pool is properly closed on application shutdown 4. Add a test that calls an authenticated endpoint many times in rapid succession and confirms the number of open DB connections stays bounded ## Acceptance criteria - A single `DatabaseClient` instance is shared across all auth requests - No new client is created per request in `auth.py` - Connection pool size is configurable via env var - Load test or unit test confirms bounded connection count ## References Roadmap item: P1 Error handling and resilience -- `get_db_client()` creates a new `DatabaseClient` on every call
AI-Manager added the P1agent-readymediumrefactor labels 2026-03-29 01:21:52 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready medium refactor
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#801
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?