leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add tests for JWT authentication flow and admin-only endpoints #804

New Issue
Closed
opened 2026-03-29 01:22:16 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-29 01:22:16 +00:00
Owner
Copy Link
Copy Source

Background

Existing API tests in tests/test_api.py bypass authentication entirely. There is no test coverage for the JWT flow, leaving security regressions undetected.

What to do

Add a new test file (e.g., tests/test_auth.py) covering:

  1. Registration -- successful registration, duplicate username rejected
  2. Login -- correct credentials return a JWT, wrong credentials return 401
  3. Protected route access -- valid token grants access, missing/expired/invalid token returns 401
  4. Token refresh -- refresh endpoint issues a new valid token
  5. Admin-only endpoints -- non-admin user receives 403, admin user succeeds

Use pytest fixtures for test user setup and teardown.

Acceptance criteria

  • All 5 scenarios above have at least one test each
  • Tests run in CI (see also: CI test job issue)
  • No production credentials are hardcoded in tests
  • Coverage for auth.py reaches at least 80%

References

Roadmap item: P1 Test coverage for auth and admin

## Background Existing API tests in `tests/test_api.py` bypass authentication entirely. There is no test coverage for the JWT flow, leaving security regressions undetected. ## What to do Add a new test file (e.g., `tests/test_auth.py`) covering: 1. **Registration** -- successful registration, duplicate username rejected 2. **Login** -- correct credentials return a JWT, wrong credentials return 401 3. **Protected route access** -- valid token grants access, missing/expired/invalid token returns 401 4. **Token refresh** -- refresh endpoint issues a new valid token 5. **Admin-only endpoints** -- non-admin user receives 403, admin user succeeds Use pytest fixtures for test user setup and teardown. ## Acceptance criteria - All 5 scenarios above have at least one test each - Tests run in CI (see also: CI test job issue) - No production credentials are hardcoded in tests - Coverage for `auth.py` reaches at least 80% ## References Roadmap item: P1 Test coverage for auth and admin
AI-Manager added the P1agent-readymediumtest labels 2026-03-29 01:22:16 +00:00
AI-Manager commented 2026-03-29 02:04:27 +00:00
Author
Owner
Copy Link
Copy Source

This issue has already been resolved and merged into main via PR #35 (test(auth): add comprehensive JWT authentication test suite). Closing as completed.

This issue has already been resolved and merged into main via PR #35 (test(auth): add comprehensive JWT authentication test suite). Closing as completed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready medium test
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#804
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?