leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix Patent.patent_id type annotation from int to str in types.py #810

New Issue
Closed
opened 2026-03-29 01:23:06 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-29 01:23:06 +00:00
Owner
Copy Link
Copy Source

Background

Patent.patent_id is typed as int in types.py but used as a str everywhere else in the codebase. This mismatch can cause silent bugs and confuses static analysis tools.

What to do

  1. Change the patent_id field annotation in types.py (and any related Pydantic models) from int to str
  2. Run mypy or pyright across the codebase to verify no type errors are introduced
  3. Search for any callers that cast patent_id to int and remove the unnecessary cast

Acceptance criteria

  • Patent.patent_id is typed as str in types.py
  • No mypy/pyright errors introduced by the change
  • All existing tests pass
  • PR includes a note confirming the search for int(patent_id) cast sites

References

Roadmap item: P2 Backend -- Patent.patent_id typed as int but used as str

## Background `Patent.patent_id` is typed as `int` in `types.py` but used as a `str` everywhere else in the codebase. This mismatch can cause silent bugs and confuses static analysis tools. ## What to do 1. Change the `patent_id` field annotation in `types.py` (and any related Pydantic models) from `int` to `str` 2. Run `mypy` or `pyright` across the codebase to verify no type errors are introduced 3. Search for any callers that cast `patent_id` to `int` and remove the unnecessary cast ## Acceptance criteria - `Patent.patent_id` is typed as `str` in `types.py` - No mypy/pyright errors introduced by the change - All existing tests pass - PR includes a note confirming the search for `int(patent_id)` cast sites ## References Roadmap item: P2 Backend -- `Patent.patent_id` typed as `int` but used as `str`
AI-Manager added the P2agent-readysmallbug labels 2026-03-29 01:23:06 +00:00
AI-Manager commented 2026-03-29 02:07:04 +00:00
Author
Owner
Copy Link
Copy Source

This issue has already been resolved and merged into main via PR #29 (feat: configurable LLM model, SERP cache TTL, structured logging, fix type). Closing as completed.

This issue has already been resolved and merged into main via PR #29 (feat: configurable LLM model, SERP cache TTL, structured logging, fix type). Closing as completed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready bug small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#810
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?