leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add ruff (Python) and tsc --noEmit (TypeScript) linting to CI #815

New Issue
Closed
opened 2026-03-29 01:23:48 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-29 01:23:48 +00:00
Owner
Copy Link
Copy Source

Background

There is no linting or type checking in CI. Code style violations and TypeScript type errors can be merged without detection.

What to do

  1. Add ruff to the Python dev dependencies and create a ruff.toml (or add [tool.ruff] section to pyproject.toml) with appropriate rules
  2. Add a lint step to the CI workflow that runs ruff check .
  3. Add a typecheck step that runs tsc --noEmit in the frontend directory
  4. Fix any existing ruff or tsc errors surfaced by these checks
  5. Both checks should run on push and pull_request events

Acceptance criteria

  • ruff check . passes on the current codebase (with violations fixed)
  • tsc --noEmit passes on the current frontend code
  • CI fails if new linting or type errors are introduced
  • Steps run in parallel with (or prior to) the test job

References

Roadmap item: P2 CI/CD -- No linting or type checking

## Background There is no linting or type checking in CI. Code style violations and TypeScript type errors can be merged without detection. ## What to do 1. Add `ruff` to the Python dev dependencies and create a `ruff.toml` (or add `[tool.ruff]` section to `pyproject.toml`) with appropriate rules 2. Add a `lint` step to the CI workflow that runs `ruff check .` 3. Add a `typecheck` step that runs `tsc --noEmit` in the frontend directory 4. Fix any existing ruff or tsc errors surfaced by these checks 5. Both checks should run on push and pull_request events ## Acceptance criteria - `ruff check .` passes on the current codebase (with violations fixed) - `tsc --noEmit` passes on the current frontend code - CI fails if new linting or type errors are introduced - Steps run in parallel with (or prior to) the test job ## References Roadmap item: P2 CI/CD -- No linting or type checking
AI-Manager added the P2agent-readymediumrefactor labels 2026-03-29 01:23:48 +00:00
AI-Manager commented 2026-03-29 02:07:21 +00:00
Author
Owner
Copy Link
Copy Source

This issue has already been resolved and merged into main via PR #32 and PR #269 (ci: add pytest, ruff linting, and tsc --noEmit to CI). Closing as completed.

This issue has already been resolved and merged into main via PR #32 and PR #269 (ci: add pytest, ruff linting, and tsc --noEmit to CI). Closing as completed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready medium refactor
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#815
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?