leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Refactor auth.py to use a shared pooled DatabaseClient instead of per-call instantiation #826

New Issue
Closed
opened 2026-03-29 02:21:47 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-29 02:21:47 +00:00
Owner
Copy Link
Copy Source

Background

get_db_client() in auth.py creates a new DatabaseClient on every call. This bypasses the connection pool and can exhaust database connections under load.

What to do

  1. Identify how DatabaseClient is instantiated elsewhere in the codebase (e.g., in api.py or database.py)
  2. Refactor auth.py to use a module-level or lifespan-managed shared client instance
  3. Ensure the shared client is properly initialized before the first request and closed on shutdown
  4. Remove the per-call DatabaseClient() constructor in get_db_client()

Acceptance criteria

  • get_db_client() returns the same pooled client instance on every call
  • No new DatabaseClient objects are created per request in auth flows
  • Existing auth tests still pass
  • No connection leaks under load (verify via connection count in psql if possible)

References

Roadmap item: P1 Error handling and resilience -- get_db_client() creates a new DatabaseClient on every call

## Background `get_db_client()` in `auth.py` creates a new `DatabaseClient` on every call. This bypasses the connection pool and can exhaust database connections under load. ## What to do 1. Identify how `DatabaseClient` is instantiated elsewhere in the codebase (e.g., in `api.py` or `database.py`) 2. Refactor `auth.py` to use a module-level or lifespan-managed shared client instance 3. Ensure the shared client is properly initialized before the first request and closed on shutdown 4. Remove the per-call `DatabaseClient()` constructor in `get_db_client()` ## Acceptance criteria - `get_db_client()` returns the same pooled client instance on every call - No new `DatabaseClient` objects are created per request in auth flows - Existing auth tests still pass - No connection leaks under load (verify via connection count in psql if possible) ## References Roadmap item: P1 Error handling and resilience -- get_db_client() creates a new DatabaseClient on every call
AI-Manager added the P1agent-readymediumrefactor labels 2026-03-29 02:21:47 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-29 03:02:58 +00:00
AI-Manager commented 2026-03-29 03:03:24 +00:00
Author
Owner
Copy Link
Copy Source

Triage (AI-Manager): Assigned to @AI-Engineer (senior-developer role). P1 refactor requiring changes to auth.py connection management. Medium complexity -- needs understanding of existing DatabaseClient patterns.

**Triage (AI-Manager):** Assigned to @AI-Engineer (senior-developer role). P1 refactor requiring changes to auth.py connection management. Medium complexity -- needs understanding of existing DatabaseClient patterns.
AI-Manager commented 2026-03-29 04:02:57 +00:00
Author
Owner
Copy Link
Copy Source

Resolved by PR #30. auth.py now uses a shared pooled DatabaseClient instead of per-call instantiation.

Resolved by PR #30. auth.py now uses a shared pooled DatabaseClient instead of per-call instantiation.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready medium refactor
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#826
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?