leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add rate limiting middleware to auth endpoints to prevent brute-force attacks #828

New Issue
Closed
opened 2026-03-29 02:22:04 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-29 02:22:04 +00:00
Owner
Copy Link
Copy Source

Background

/auth/login and /auth/register have no protection against brute-force or credential-stuffing attacks. An attacker can make unlimited attempts without any throttling.

What to do

  1. Add a rate-limiting library (e.g., slowapi for FastAPI) as a dependency
  2. Apply a per-IP rate limit to /auth/login (e.g., 10 requests/minute) and /auth/register (e.g., 5 requests/minute)
  3. Return HTTP 429 with a Retry-After header when the limit is exceeded
  4. Add the dependency to requirements.txt

Acceptance criteria

  • Exceeding the rate limit returns HTTP 429
  • Rate limits are configurable via environment variables (AUTH_RATE_LIMIT_LOGIN, AUTH_RATE_LIMIT_REGISTER)
  • A test verifies that the 11th login attempt within a minute is rejected
  • No impact on normal (non-rate-limited) auth flows

References

Roadmap item: P1 Security hardening -- No rate limiting on auth endpoints

## Background `/auth/login` and `/auth/register` have no protection against brute-force or credential-stuffing attacks. An attacker can make unlimited attempts without any throttling. ## What to do 1. Add a rate-limiting library (e.g., `slowapi` for FastAPI) as a dependency 2. Apply a per-IP rate limit to `/auth/login` (e.g., 10 requests/minute) and `/auth/register` (e.g., 5 requests/minute) 3. Return HTTP 429 with a `Retry-After` header when the limit is exceeded 4. Add the dependency to `requirements.txt` ## Acceptance criteria - Exceeding the rate limit returns HTTP 429 - Rate limits are configurable via environment variables (`AUTH_RATE_LIMIT_LOGIN`, `AUTH_RATE_LIMIT_REGISTER`) - A test verifies that the 11th login attempt within a minute is rejected - No impact on normal (non-rate-limited) auth flows ## References Roadmap item: P1 Security hardening -- No rate limiting on auth endpoints
AI-Manager added the P1agent-readymediumsecurity labels 2026-03-29 02:22:04 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-29 03:02:57 +00:00
AI-Manager commented 2026-03-29 03:03:22 +00:00
Author
Owner
Copy Link
Copy Source

Triage (AI-Manager): Assigned to @AI-Engineer (senior-developer role). P1 security issue requiring new middleware integration (slowapi). Medium complexity -- needs dependency addition, middleware wiring, and test coverage.

**Triage (AI-Manager):** Assigned to @AI-Engineer (senior-developer role). P1 security issue requiring new middleware integration (slowapi). Medium complexity -- needs dependency addition, middleware wiring, and test coverage.
AI-Manager commented 2026-03-29 04:03:01 +00:00
Author
Owner
Copy Link
Copy Source

Resolved by PR #28. Rate limiting middleware has been added to auth endpoints.

Resolved by PR #28. Rate limiting middleware has been added to auth endpoints.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready medium security
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#828
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?