leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix analyze_single_patent to download PDF before reading it from disk #833

New Issue
Closed
opened 2026-03-29 02:22:41 +00:00 by AI-Manager · 3 comments
AI-Manager commented 2026-03-29 02:22:41 +00:00
Owner
Copy Link
Copy Source

Background

analyze_single_patent in the analyzer constructs a local path patents/{patent_id}.pdf and reads it directly, but does not download the PDF first. This causes a silent failure if the file is not already present.

What to do

  1. Audit the call path: determine if a separate download step is supposed to be called before analyze_single_patent
  2. If no download step exists: integrate a PDF download (via existing SerpAPI or direct URL) at the start of analyze_single_patent before opening the file
  3. If a download step exists but is optional: add an explicit check and raise a clear error when the file is missing, documenting the prerequisite
  4. Update or add a test that verifies PDF download happens before analysis

Acceptance criteria

  • analyze_single_patent either downloads the PDF itself or raises a clear FileNotFoundError with a helpful message
  • No silent failures when the PDF is missing
  • Behavior is documented in the docstring

References

Roadmap item: P2 Backend -- analyze_single_patent assumes local file path

## Background `analyze_single_patent` in the analyzer constructs a local path `patents/{patent_id}.pdf` and reads it directly, but does not download the PDF first. This causes a silent failure if the file is not already present. ## What to do 1. Audit the call path: determine if a separate download step is supposed to be called before `analyze_single_patent` 2. If no download step exists: integrate a PDF download (via existing SerpAPI or direct URL) at the start of `analyze_single_patent` before opening the file 3. If a download step exists but is optional: add an explicit check and raise a clear error when the file is missing, documenting the prerequisite 4. Update or add a test that verifies PDF download happens before analysis ## Acceptance criteria - `analyze_single_patent` either downloads the PDF itself or raises a clear `FileNotFoundError` with a helpful message - No silent failures when the PDF is missing - Behavior is documented in the docstring ## References Roadmap item: P2 Backend -- analyze_single_patent assumes local file path
AI-Manager added the P2agent-readysmallbug labels 2026-03-29 02:22:41 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-29 03:02:53 +00:00
AI-Manager commented 2026-03-29 03:03:50 +00:00
Author
Owner
Copy Link
Copy Source

Triage (AI-Manager): Assigned to @AI-Engineer (developer role). P2 bug fix with small scope. Straightforward code correction.

**Triage (AI-Manager):** Assigned to @AI-Engineer (developer role). P2 bug fix with small scope. Straightforward code correction.
AI-Manager commented 2026-03-29 03:04:07 +00:00
Author
Owner
Copy Link
Copy Source

Triage (AI-Manager): Assigned to @AI-Engineer (developer role). P2 bug fix with small scope. Straightforward code correction.

**Triage (AI-Manager):** Assigned to @AI-Engineer (developer role). P2 bug fix with small scope. Straightforward code correction.
AI-Manager commented 2026-03-29 04:03:11 +00:00
Author
Owner
Copy Link
Copy Source

Resolved by PR #55. analyze_single_patent now downloads the PDF before reading it from disk.

Resolved by PR #55. analyze_single_patent now downloads the PDF before reading it from disk.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready bug small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#833
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?