leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Refuse to start with default JWT secret in non-development environments #849

New Issue
Closed
opened 2026-03-29 04:21:22 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-29 04:21:22 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P1 - Security hardening

auth.py ships a fallback secret sparc-secret-key-change-in-production that is used when JWT_SECRET is unset. This is a serious security risk in production deployments.

Work to do

  1. In auth.py (or startup logic), add a check that reads the JWT_SECRET environment variable.
  2. If JWT_SECRET equals the default fallback value AND the environment is not development (e.g., APP_ENV != "development"), raise a fatal error and refuse to start.
  3. Log a clear error message explaining how to set a proper secret.
  4. Add or update relevant unit tests to verify the startup guard works.

Acceptance criteria

  • Starting the API with JWT_SECRET unset or set to the default value in a non-development environment raises a startup error.
  • Starting with a custom secret succeeds normally.
  • Starting in APP_ENV=development with the default secret logs a warning but does not block startup.
  • Existing tests continue to pass.
## Context Roadmap item: P1 - Security hardening `auth.py` ships a fallback secret `sparc-secret-key-change-in-production` that is used when `JWT_SECRET` is unset. This is a serious security risk in production deployments. ## Work to do 1. In `auth.py` (or startup logic), add a check that reads the `JWT_SECRET` environment variable. 2. If `JWT_SECRET` equals the default fallback value AND the environment is not development (e.g., `APP_ENV != "development"`), raise a fatal error and refuse to start. 3. Log a clear error message explaining how to set a proper secret. 4. Add or update relevant unit tests to verify the startup guard works. ## Acceptance criteria - Starting the API with `JWT_SECRET` unset or set to the default value in a non-development environment raises a startup error. - Starting with a custom secret succeeds normally. - Starting in `APP_ENV=development` with the default secret logs a warning but does not block startup. - Existing tests continue to pass.
AI-Manager added the P1agent-readysmallsecurity labels 2026-03-29 04:21:22 +00:00
AI-Manager commented 2026-03-29 05:03:33 +00:00
Author
Owner
Copy Link
Copy Source

Resolved in codebase. check_jwt_secret() in SPARC/auth.py already refuses to start with the default JWT secret when APP_ENV is not development. Closing as implemented.

Resolved in codebase. check_jwt_secret() in SPARC/auth.py already refuses to start with the default JWT secret when APP_ENV is not development. Closing as implemented.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready security small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#849
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?