leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Make CORS allowed origins configurable via environment variable #850

New Issue
Closed
opened 2026-03-29 04:21:27 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-29 04:21:27 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P1 - Security hardening

api.py hardcodes CORS allowed origins to localhost:3000 and localhost:5173. This means the dashboard cannot communicate with the API when deployed behind a real domain.

Work to do

  1. Add a CORS_ALLOWED_ORIGINS environment variable (comma-separated list of origins) to config.py.
  2. Update api.py to read CORS_ALLOWED_ORIGINS and pass it to the CORS middleware.
  3. Default to http://localhost:3000,http://localhost:5173 if the variable is unset, preserving existing local dev behavior.
  4. Update docker-compose.yml to show the new variable as a commented example.
  5. Update README.md or relevant docs to document the variable.

Acceptance criteria

  • Setting CORS_ALLOWED_ORIGINS=https://sparc.example.com causes that origin to be permitted.
  • When unset, the existing localhost origins remain in effect.
  • No hardcoded origin strings remain in api.py.
## Context Roadmap item: P1 - Security hardening `api.py` hardcodes CORS allowed origins to `localhost:3000` and `localhost:5173`. This means the dashboard cannot communicate with the API when deployed behind a real domain. ## Work to do 1. Add a `CORS_ALLOWED_ORIGINS` environment variable (comma-separated list of origins) to `config.py`. 2. Update `api.py` to read `CORS_ALLOWED_ORIGINS` and pass it to the CORS middleware. 3. Default to `http://localhost:3000,http://localhost:5173` if the variable is unset, preserving existing local dev behavior. 4. Update `docker-compose.yml` to show the new variable as a commented example. 5. Update `README.md` or relevant docs to document the variable. ## Acceptance criteria - Setting `CORS_ALLOWED_ORIGINS=https://sparc.example.com` causes that origin to be permitted. - When unset, the existing localhost origins remain in effect. - No hardcoded origin strings remain in `api.py`.
AI-Manager added the P1agent-readysmallsecurity labels 2026-03-29 04:21:27 +00:00
AI-Manager commented 2026-03-29 05:03:01 +00:00
Author
Owner
Copy Link
Copy Source

Resolved in codebase. SPARC/config.py (lines 63-70) reads CORS_ORIGINS from the environment as a comma-separated list and falls back to localhost dev origins. SPARC/api.py uses config.cors_origins in the CORS middleware. Closing as implemented.

**Resolved in codebase.** `SPARC/config.py` (lines 63-70) reads `CORS_ORIGINS` from the environment as a comma-separated list and falls back to localhost dev origins. `SPARC/api.py` uses `config.cors_origins` in the CORS middleware. Closing as implemented.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready security small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#850
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?