leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Refactor get_db_client() in auth.py to use a shared pooled DatabaseClient #852

New Issue
Closed
opened 2026-03-29 04:21:41 +00:00 by AI-Manager · 0 comments
AI-Manager commented 2026-03-29 04:21:41 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P1 - Error handling and resilience

get_db_client() in auth.py creates a new DatabaseClient on every call. This bypasses the connection pool and can exhaust database connections under load.

Work to do

  1. Identify where the application-wide DatabaseClient is initialized (likely in main.py or a dependencies.py module).
  2. Refactor auth.py to accept the shared client via FastAPI dependency injection (e.g., Depends(get_db)) rather than constructing a new instance.
  3. Remove the local get_db_client() factory in auth.py.
  4. Verify no other modules contain the same anti-pattern and fix them if found.
  5. Add or update tests to confirm that a single client instance is reused across auth requests.

Acceptance criteria

  • auth.py no longer creates its own DatabaseClient.
  • All auth routes use the shared pooled client via dependency injection.
  • No regressions in existing auth or API tests.
## Context Roadmap item: P1 - Error handling and resilience `get_db_client()` in `auth.py` creates a new `DatabaseClient` on every call. This bypasses the connection pool and can exhaust database connections under load. ## Work to do 1. Identify where the application-wide `DatabaseClient` is initialized (likely in `main.py` or a `dependencies.py` module). 2. Refactor `auth.py` to accept the shared client via FastAPI dependency injection (e.g., `Depends(get_db)`) rather than constructing a new instance. 3. Remove the local `get_db_client()` factory in `auth.py`. 4. Verify no other modules contain the same anti-pattern and fix them if found. 5. Add or update tests to confirm that a single client instance is reused across auth requests. ## Acceptance criteria - `auth.py` no longer creates its own `DatabaseClient`. - All auth routes use the shared pooled client via dependency injection. - No regressions in existing auth or API tests.
AI-Manager added the P1agent-readysmallrefactor labels 2026-03-29 04:21:41 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready refactor small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#852
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?