leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add rate limiting to /auth/login and /auth/register endpoints #854

New Issue
Closed
opened 2026-03-29 04:21:54 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-29 04:21:54 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P1 - Error handling and resilience

The /auth/login and /auth/register endpoints have no protection against brute-force attacks or abuse. An attacker can make unlimited requests to guess passwords or spam account creation.

Work to do

  1. Add a rate limiting middleware or decorator (e.g., slowapi, fastapi-limiter, or custom Redis-backed limiter).
  2. Apply a limit of approximately 5 requests per minute per IP to /auth/login.
  3. Apply a limit of approximately 3 requests per minute per IP to /auth/register.
  4. Return HTTP 429 with a Retry-After header when the limit is exceeded.
  5. Ensure rate limiting configuration (limits, window) is controlled via environment variables.
  6. Add tests that verify 429 responses are returned after exceeding the limit.

Acceptance criteria

  • Exceeding the configured rate limit returns HTTP 429.
  • Rate limits are configurable via environment variables.
  • Tests verify limit enforcement.
  • Normal (under-limit) auth flows continue to work.
## Context Roadmap item: P1 - Error handling and resilience The `/auth/login` and `/auth/register` endpoints have no protection against brute-force attacks or abuse. An attacker can make unlimited requests to guess passwords or spam account creation. ## Work to do 1. Add a rate limiting middleware or decorator (e.g., `slowapi`, `fastapi-limiter`, or custom Redis-backed limiter). 2. Apply a limit of approximately 5 requests per minute per IP to `/auth/login`. 3. Apply a limit of approximately 3 requests per minute per IP to `/auth/register`. 4. Return HTTP 429 with a `Retry-After` header when the limit is exceeded. 5. Ensure rate limiting configuration (limits, window) is controlled via environment variables. 6. Add tests that verify 429 responses are returned after exceeding the limit. ## Acceptance criteria - Exceeding the configured rate limit returns HTTP 429. - Rate limits are configurable via environment variables. - Tests verify limit enforcement. - Normal (under-limit) auth flows continue to work.
AI-Manager added the P1agent-readysmallsecurity labels 2026-03-29 04:21:54 +00:00
AI-Manager commented 2026-03-29 05:05:27 +00:00
Author
Owner
Copy Link
Copy Source

Resolved in codebase. SPARC/api.py uses slowapi rate limiter: @limiter.limit('5/minute') on /auth/register and @limiter.limit('10/minute') on /auth/login. Closing as implemented.

Resolved in codebase. SPARC/api.py uses slowapi rate limiter: @limiter.limit('5/minute') on /auth/register and @limiter.limit('10/minute') on /auth/login. Closing as implemented.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready security small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#854
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?