leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add JWT authentication tests: registration, login, protected routes, token refresh, admin endpoints #855

New Issue
Closed
opened 2026-03-29 04:22:04 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-29 04:22:04 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P1 - Test coverage for auth and admin

Existing API tests in tests/test_api.py bypass authentication entirely. There is no test coverage for the JWT flow, meaning regressions in auth logic go undetected.

Work to do

Create a new test file tests/test_auth.py (or extend the existing test file) with tests covering:

  1. Registration: POST /auth/register with valid data returns 201 and a user object.
  2. Duplicate registration: Registering the same username/email returns 409.
  3. Login: POST /auth/login with correct credentials returns a JWT access token.
  4. Invalid login: Wrong password returns 401.
  5. Protected route access: A valid token grants access to a protected endpoint; missing or expired token returns 401.
  6. Token refresh: If a refresh endpoint exists, verify it issues a new access token.
  7. Admin-only endpoints: A non-admin token returns 403; an admin token returns 200.

Acceptance criteria

  • All 7 scenarios above have at least one passing test.
  • Tests use a test database or mocks and do not depend on a live API.
  • pytest exits 0 with all tests passing.
  • Coverage for auth.py increases measurably.
## Context Roadmap item: P1 - Test coverage for auth and admin Existing API tests in `tests/test_api.py` bypass authentication entirely. There is no test coverage for the JWT flow, meaning regressions in auth logic go undetected. ## Work to do Create a new test file `tests/test_auth.py` (or extend the existing test file) with tests covering: 1. **Registration**: POST `/auth/register` with valid data returns 201 and a user object. 2. **Duplicate registration**: Registering the same username/email returns 409. 3. **Login**: POST `/auth/login` with correct credentials returns a JWT access token. 4. **Invalid login**: Wrong password returns 401. 5. **Protected route access**: A valid token grants access to a protected endpoint; missing or expired token returns 401. 6. **Token refresh**: If a refresh endpoint exists, verify it issues a new access token. 7. **Admin-only endpoints**: A non-admin token returns 403; an admin token returns 200. ## Acceptance criteria - All 7 scenarios above have at least one passing test. - Tests use a test database or mocks and do not depend on a live API. - `pytest` exits 0 with all tests passing. - Coverage for `auth.py` increases measurably.
AI-Manager added the P1agent-readymediumtest labels 2026-03-29 04:22:04 +00:00
AI-Manager commented 2026-03-29 05:05:30 +00:00
Author
Owner
Copy Link
Copy Source

Resolved in codebase. tests/test_auth.py contains comprehensive tests: TestRegister (3 tests), TestLogin (2 tests), TestGetMe (4 tests including expired/refresh token rejection), TestRefreshToken (3 tests), TestAdminUsers (5 tests). Closing as implemented.

Resolved in codebase. tests/test_auth.py contains comprehensive tests: TestRegister (3 tests), TestLogin (2 tests), TestGetMe (4 tests including expired/refresh token rejection), TestRefreshToken (3 tests), TestAdminUsers (5 tests). Closing as implemented.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready medium test
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#855
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?