leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Replace print() calls with structured logging in analyzer.py, serp_api.py, and llm.py #856

New Issue
Closed
opened 2026-03-29 04:22:14 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-29 04:22:14 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P2 - Backend - Add structured logging

analyzer.py, serp_api.py, and llm.py use print() for diagnostic output. This makes it impossible to filter by log level, redirect logs to a collector, or control verbosity without code changes.

Work to do

  1. Add a logging setup module (or configure in main.py) that formats log records as JSON or structured text and respects a LOG_LEVEL environment variable (default INFO).
  2. Replace every print() call in analyzer.py, serp_api.py, and llm.py with the appropriate logger.debug/info/warning/error call.
  3. Scan the rest of the codebase for stray print() calls and convert those as well.
  4. Ensure that sensitive data (API keys, tokens) is never logged.

Acceptance criteria

  • No print() calls remain in analyzer.py, serp_api.py, or llm.py.
  • Log output respects LOG_LEVEL.
  • pytest output is not polluted by log lines at default INFO level during tests.
  • No API keys or secrets appear in log output.
## Context Roadmap item: P2 - Backend - Add structured logging `analyzer.py`, `serp_api.py`, and `llm.py` use `print()` for diagnostic output. This makes it impossible to filter by log level, redirect logs to a collector, or control verbosity without code changes. ## Work to do 1. Add a `logging` setup module (or configure in `main.py`) that formats log records as JSON or structured text and respects a `LOG_LEVEL` environment variable (default `INFO`). 2. Replace every `print()` call in `analyzer.py`, `serp_api.py`, and `llm.py` with the appropriate `logger.debug/info/warning/error` call. 3. Scan the rest of the codebase for stray `print()` calls and convert those as well. 4. Ensure that sensitive data (API keys, tokens) is never logged. ## Acceptance criteria - No `print()` calls remain in `analyzer.py`, `serp_api.py`, or `llm.py`. - Log output respects `LOG_LEVEL`. - `pytest` output is not polluted by log lines at default `INFO` level during tests. - No API keys or secrets appear in log output.
AI-Manager added the P2agent-readymediumrefactor labels 2026-03-29 04:22:14 +00:00
AI-Manager commented 2026-03-29 05:05:32 +00:00
Author
Owner
Copy Link
Copy Source

Resolved in codebase. All print() calls have been replaced with logging. SPARC/config.py configures logging.basicConfig() with LOG_LEVEL env var. analyzer.py, serp_api.py, and llm.py all use logger = logging.getLogger(name). No print() calls remain in the SPARC package. Closing as implemented.

Resolved in codebase. All print() calls have been replaced with logging. SPARC/config.py configures logging.basicConfig() with LOG_LEVEL env var. analyzer.py, serp_api.py, and llm.py all use logger = logging.getLogger(__name__). No print() calls remain in the SPARC package. Closing as implemented.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready medium refactor
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#856
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?