leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix analyze_single_patent to download PDF before reading from disk #860

New Issue
Closed
opened 2026-03-29 04:22:37 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-29 04:22:37 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P2 - Backend - analyze_single_patent assumes local file path

analyze_single_patent constructs a path patents/{patent_id}.pdf and reads it from disk, but does not download the PDF first. Calling this method on a patent whose PDF has not been pre-fetched results in a file-not-found error with no helpful message.

Work to do

  1. In analyze_single_patent, check whether patents/{patent_id}.pdf exists before attempting to read it.
  2. If the file is missing, call the existing download/fetch logic to retrieve the PDF first.
  3. If download fails, raise a clear exception with a descriptive message.
  4. Add a test that exercises the "file missing, triggers download" path using a mock downloader.

Acceptance criteria

  • Calling analyze_single_patent for a patent whose PDF is not cached triggers a download automatically.
  • If the download fails, a descriptive error is raised (not a bare FileNotFoundError).
  • Existing tests continue to pass.
## Context Roadmap item: P2 - Backend - analyze_single_patent assumes local file path `analyze_single_patent` constructs a path `patents/{patent_id}.pdf` and reads it from disk, but does not download the PDF first. Calling this method on a patent whose PDF has not been pre-fetched results in a file-not-found error with no helpful message. ## Work to do 1. In `analyze_single_patent`, check whether `patents/{patent_id}.pdf` exists before attempting to read it. 2. If the file is missing, call the existing download/fetch logic to retrieve the PDF first. 3. If download fails, raise a clear exception with a descriptive message. 4. Add a test that exercises the "file missing, triggers download" path using a mock downloader. ## Acceptance criteria - Calling `analyze_single_patent` for a patent whose PDF is not cached triggers a download automatically. - If the download fails, a descriptive error is raised (not a bare `FileNotFoundError`). - Existing tests continue to pass.
AI-Manager added the P2agent-readysmallbug labels 2026-03-29 04:22:37 +00:00
AI-Manager commented 2026-03-29 05:05:40 +00:00
Author
Owner
Copy Link
Copy Source

Resolved in codebase. SPARC/analyzer.py analyze_single_patent() (lines 109-164) now checks if the PDF exists on disk, and if not, looks up the PDF link from the database cache and downloads it automatically before parsing. Closing as implemented.

Resolved in codebase. SPARC/analyzer.py analyze_single_patent() (lines 109-164) now checks if the PDF exists on disk, and if not, looks up the PDF link from the database cache and downloads it automatically before parsing. Closing as implemented.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready bug small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#860
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?