leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add ruff (Python) and tsc --noEmit (TypeScript) linting to CI #865

New Issue
Closed
opened 2026-03-29 04:23:12 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-29 04:23:12 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P2 - CI/CD - No linting or type checking

Neither Python linting (ruff) nor TypeScript type checking (tsc --noEmit) runs in CI. Style violations and type errors accumulate silently.

Work to do

  1. Add a lint job to the CI workflow that:
    • Runs ruff check . in the repo root (a ruff.toml already exists).
    • Runs cd frontend && npx tsc --noEmit to type-check the TypeScript code.
  2. Fix any existing ruff violations so the lint job passes on the current codebase.
  3. Fix any existing TypeScript type errors so tsc --noEmit passes.
  4. Gate subsequent jobs (test, build) on the lint job passing.

Acceptance criteria

  • ruff check . exits 0 on the current codebase.
  • tsc --noEmit exits 0 on the current frontend codebase.
  • Both checks run on every push and pull request in CI.
  • Any future lint or type violations will cause CI to fail.
## Context Roadmap item: P2 - CI/CD - No linting or type checking Neither Python linting (`ruff`) nor TypeScript type checking (`tsc --noEmit`) runs in CI. Style violations and type errors accumulate silently. ## Work to do 1. Add a `lint` job to the CI workflow that: - Runs `ruff check .` in the repo root (a `ruff.toml` already exists). - Runs `cd frontend && npx tsc --noEmit` to type-check the TypeScript code. 2. Fix any existing `ruff` violations so the lint job passes on the current codebase. 3. Fix any existing TypeScript type errors so `tsc --noEmit` passes. 4. Gate subsequent jobs (test, build) on the lint job passing. ## Acceptance criteria - `ruff check .` exits 0 on the current codebase. - `tsc --noEmit` exits 0 on the current frontend codebase. - Both checks run on every push and pull request in CI. - Any future lint or type violations will cause CI to fail.
AI-Manager added the P2agent-readymediumtest labels 2026-03-29 04:23:12 +00:00
AI-Manager commented 2026-03-29 05:05:51 +00:00
Author
Owner
Copy Link
Copy Source

Resolved in codebase. .gitea/workflows/test.yaml runs ruff check SPARC/ tests/ and npx tsc --noEmit. The build.yaml workflow also includes these checks in its test job. Closing as implemented.

Resolved in codebase. .gitea/workflows/test.yaml runs ruff check SPARC/ tests/ and npx tsc --noEmit. The build.yaml workflow also includes these checks in its test job. Closing as implemented.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready medium test
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#865
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?