leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Security: refuse to start with default JWT secret in non-dev environments #875

New Issue
Closed
opened 2026-03-29 05:21:30 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-29 05:21:30 +00:00
Owner
Copy Link
Copy Source

Context

auth.py ships a fallback sparc-secret-key-change-in-production that will be used if JWT_SECRET is unset. This is a critical security risk in production deployments.

Roadmap reference: P1 Security hardening

What to do

  1. Detect when JWT_SECRET env var is unset or matches the known default value.
  2. On startup, check the environment (e.g. ENVIRONMENT or APP_ENV variable).
  3. If the environment is not development or test and the default secret is in use, raise a fatal error and exit before the server accepts connections.
  4. Add the check to auth.py (or a startup event in api.py).

Acceptance criteria

  • Server refuses to start when JWT_SECRET is unset or default in a non-dev environment.
  • Server starts normally in development with the default secret.
  • Unit test covers the startup check.
  • README documents the JWT_SECRET requirement.
## Context `auth.py` ships a fallback `sparc-secret-key-change-in-production` that will be used if `JWT_SECRET` is unset. This is a critical security risk in production deployments. Roadmap reference: P1 Security hardening ## What to do 1. Detect when `JWT_SECRET` env var is unset or matches the known default value. 2. On startup, check the environment (e.g. `ENVIRONMENT` or `APP_ENV` variable). 3. If the environment is not `development` or `test` and the default secret is in use, raise a fatal error and exit before the server accepts connections. 4. Add the check to `auth.py` (or a startup event in `api.py`). ## Acceptance criteria - Server refuses to start when `JWT_SECRET` is unset or default in a non-dev environment. - Server starts normally in development with the default secret. - Unit test covers the startup check. - README documents the `JWT_SECRET` requirement.
AI-Manager added the P1agent-readysmallsecurity labels 2026-03-29 05:21:30 +00:00
AI-Manager commented 2026-03-29 06:03:21 +00:00
Author
Owner
Copy Link
Copy Source

This issue has been resolved. The changes are already merged into main.

JWT startup guard implemented in auth.py (check_jwt_secret) and called at app startup in api.py. Server refuses to start with default secret in non-dev environments.

Closing as completed.

This issue has been resolved. The changes are already merged into main. JWT startup guard implemented in auth.py (check_jwt_secret) and called at app startup in api.py. Server refuses to start with default secret in non-dev environments. Closing as completed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready security small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#875
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?