leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Security: make CORS allowed origins configurable via environment variable #876

New Issue
Closed
opened 2026-03-29 05:21:37 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-29 05:21:37 +00:00
Owner
Copy Link
Copy Source

Context

api.py hardcodes CORS allowed origins to localhost:3000 and localhost:5173. This breaks the dashboard when deployed behind a real domain.

Roadmap reference: P1 Security hardening

What to do

  1. Add a CORS_ALLOWED_ORIGINS environment variable to config.py (comma-separated list of origins).
  2. Update api.py to read allowed origins from config rather than hardcoding.
  3. Default to localhost:3000,localhost:5173 in development to avoid breaking local dev.
  4. Document the variable in .env.example and README.

Acceptance criteria

  • CORS_ALLOWED_ORIGINS=https://sparc.example.com is respected at runtime.
  • Default behavior (localhost only) is unchanged when the variable is unset.
  • No hardcoded origins remain in api.py.
## Context `api.py` hardcodes CORS allowed origins to `localhost:3000` and `localhost:5173`. This breaks the dashboard when deployed behind a real domain. Roadmap reference: P1 Security hardening ## What to do 1. Add a `CORS_ALLOWED_ORIGINS` environment variable to `config.py` (comma-separated list of origins). 2. Update `api.py` to read allowed origins from config rather than hardcoding. 3. Default to `localhost:3000,localhost:5173` in development to avoid breaking local dev. 4. Document the variable in `.env.example` and README. ## Acceptance criteria - `CORS_ALLOWED_ORIGINS=https://sparc.example.com` is respected at runtime. - Default behavior (localhost only) is unchanged when the variable is unset. - No hardcoded origins remain in `api.py`.
AI-Manager added the P1agent-readysmallsecurity labels 2026-03-29 05:21:37 +00:00
AI-Manager commented 2026-03-29 06:03:17 +00:00
Author
Owner
Copy Link
Copy Source

This issue has been resolved. The changes are already merged into main.

CORS origins are configurable via CORS_ORIGINS environment variable in config.py. api.py reads from config.cors_origins instead of hardcoded values.

Closing as completed.

This issue has been resolved. The changes are already merged into main. CORS origins are configurable via CORS_ORIGINS environment variable in config.py. api.py reads from config.cors_origins instead of hardcoded values. Closing as completed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready security small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#876
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?