forked from 0xWheatyz/SPARC
Security: remove plaintext database credentials from docker-compose.yml #877
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Context
docker-compose.ymlembedspostgres:postgrescredentials in plain text. These should never be committed to version control.Roadmap reference: P1 Security hardening
What to do
.env.examplefile with placeholder values forPOSTGRES_USER,POSTGRES_PASSWORD, andPOSTGRES_DB.docker-compose.ymlto reference these variables using${POSTGRES_USER}syntax..envis listed in.gitignore..env.exampleto.envand fill in values).Acceptance criteria
docker-compose.yml..envis gitignored..env.exampledocuments all required variables.docker compose upstill works when.envis present.This issue has been resolved. The changes are already merged into main.
docker-compose.yml now uses ${POSTGRES_USER}, ${POSTGRES_PASSWORD}, ${POSTGRES_DB} variables. .env.example documents all required variables.
Closing as completed.