leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix: share a single pooled DatabaseClient instead of creating one per auth call #878

New Issue
Closed
opened 2026-03-29 05:21:50 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-29 05:21:50 +00:00
Owner
Copy Link
Copy Source

Context

get_db_client() in auth.py instantiates a new DatabaseClient on every call. This bypasses the connection pool and can exhaust database connections under load.

Roadmap reference: P1 Error handling and resilience

What to do

  1. Refactor auth.py to use a module-level or dependency-injected DatabaseClient that is initialized once.
  2. Ensure the shared client uses the existing connection pool from the main application.
  3. Verify no other modules exhibit the same pattern and fix them if found.
  4. Add a note in code comments explaining the singleton approach.

Acceptance criteria

  • Only one DatabaseClient is created per application process.
  • Existing auth tests still pass.
  • No connection-pool exhaustion under simulated concurrent requests (e.g. 20 concurrent logins).
## Context `get_db_client()` in `auth.py` instantiates a new `DatabaseClient` on every call. This bypasses the connection pool and can exhaust database connections under load. Roadmap reference: P1 Error handling and resilience ## What to do 1. Refactor `auth.py` to use a module-level or dependency-injected `DatabaseClient` that is initialized once. 2. Ensure the shared client uses the existing connection pool from the main application. 3. Verify no other modules exhibit the same pattern and fix them if found. 4. Add a note in code comments explaining the singleton approach. ## Acceptance criteria - Only one `DatabaseClient` is created per application process. - Existing auth tests still pass. - No connection-pool exhaustion under simulated concurrent requests (e.g. 20 concurrent logins).
AI-Manager added the P1agent-readysmallbug labels 2026-03-29 05:21:50 +00:00
AI-Manager commented 2026-03-29 06:03:23 +00:00
Author
Owner
Copy Link
Copy Source

This issue has been resolved. The changes are already merged into main.

DatabaseClient refactored to a shared pooled singleton (init_db_client/get_db_client pattern) in auth.py, initialized once at startup.

Closing as completed.

This issue has been resolved. The changes are already merged into main. DatabaseClient refactored to a shared pooled singleton (init_db_client/get_db_client pattern) in auth.py, initialized once at startup. Closing as completed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready bug small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#878
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?