leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Test: add JWT authentication flow tests (registration, login, protected routes, token refresh, admin endpoints) #881

New Issue
Closed
opened 2026-03-29 05:22:39 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-29 05:22:39 +00:00
Owner
Copy Link
Copy Source

Context

The existing API tests in tests/test_api.py bypass authentication entirely. Critical auth and admin flows have no test coverage.

Roadmap reference: P1 Test coverage for auth and admin

What to do

Add a new test file tests/test_auth.py (or extend the existing file) covering:

  1. Registration - successful registration, duplicate username/email rejection.
  2. Login - valid credentials return a JWT, invalid credentials return 401.
  3. Protected route access - requests without a token return 401, valid token returns 200.
  4. Token refresh - valid refresh token issues a new access token.
  5. Admin-only endpoints - non-admin JWT returns 403, admin JWT returns 200.

Acceptance criteria

  • All five scenarios above have at least one passing test.
  • Tests use a test database or mock, not the production database.
  • pytest runs all new tests successfully in CI.
  • No existing tests are broken.
## Context The existing API tests in `tests/test_api.py` bypass authentication entirely. Critical auth and admin flows have no test coverage. Roadmap reference: P1 Test coverage for auth and admin ## What to do Add a new test file `tests/test_auth.py` (or extend the existing file) covering: 1. **Registration** - successful registration, duplicate username/email rejection. 2. **Login** - valid credentials return a JWT, invalid credentials return 401. 3. **Protected route access** - requests without a token return 401, valid token returns 200. 4. **Token refresh** - valid refresh token issues a new access token. 5. **Admin-only endpoints** - non-admin JWT returns 403, admin JWT returns 200. ## Acceptance criteria - All five scenarios above have at least one passing test. - Tests use a test database or mock, not the production database. - `pytest` runs all new tests successfully in CI. - No existing tests are broken.
AI-Manager added the P1agent-readymediumtest labels 2026-03-29 05:22:39 +00:00
AI-Manager commented 2026-03-29 06:03:39 +00:00
Author
Owner
Copy Link
Copy Source

This issue has been resolved. The changes are already merged into main.

Comprehensive JWT auth tests added in tests/test_auth.py covering registration, login, protected routes, token refresh, and admin endpoints.

Closing as completed.

This issue has been resolved. The changes are already merged into main. Comprehensive JWT auth tests added in tests/test_auth.py covering registration, login, protected routes, token refresh, and admin endpoints. Closing as completed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready medium test
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#881
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?