leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix: correct Patent.patent_id type annotation from int to str in types.py #886

New Issue
Closed
opened 2026-03-29 05:23:19 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-29 05:23:19 +00:00
Owner
Copy Link
Copy Source

Context

Patent.patent_id is declared as int in types.py but is used as a str everywhere else in the codebase. This type mismatch can cause subtle bugs and will flag as a mypy/pyright error.

Roadmap reference: P2 Backend - Patent.patent_id type fix

What to do

  1. Change the type annotation of Patent.patent_id from int to str in types.py.
  2. Search the codebase for any explicit int() or str() casts on patent_id that were added to paper over the mismatch and remove them if no longer needed.
  3. Run mypy or pyright to verify no remaining type errors on this field.

Acceptance criteria

  • Patent.patent_id is typed as str in types.py.
  • No runtime int/str casts exist that were compensating for the wrong annotation.
  • mypy (or equivalent) reports no type errors on the affected files.
## Context `Patent.patent_id` is declared as `int` in `types.py` but is used as a `str` everywhere else in the codebase. This type mismatch can cause subtle bugs and will flag as a mypy/pyright error. Roadmap reference: P2 Backend - Patent.patent_id type fix ## What to do 1. Change the type annotation of `Patent.patent_id` from `int` to `str` in `types.py`. 2. Search the codebase for any explicit `int()` or `str()` casts on `patent_id` that were added to paper over the mismatch and remove them if no longer needed. 3. Run mypy or pyright to verify no remaining type errors on this field. ## Acceptance criteria - `Patent.patent_id` is typed as `str` in `types.py`. - No runtime `int`/`str` casts exist that were compensating for the wrong annotation. - `mypy` (or equivalent) reports no type errors on the affected files.
AI-Manager added the P2agent-readysmallbug labels 2026-03-29 05:23:19 +00:00
AI-Manager commented 2026-03-29 06:03:29 +00:00
Author
Owner
Copy Link
Copy Source

This issue has been resolved. The changes are already merged into main.

Patent.patent_id type annotation corrected from int to str in types.py.

Closing as completed.

This issue has been resolved. The changes are already merged into main. Patent.patent_id type annotation corrected from int to str in types.py. Closing as completed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready bug small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#886
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?