leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Frontend: commit a lockfile (package-lock.json or pnpm-lock.yaml) for reproducible builds #888

New Issue
Closed
opened 2026-03-29 05:23:35 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-29 05:23:35 +00:00
Owner
Copy Link
Copy Source

Context

The frontend has no lockfile committed. Without a lockfile, npm install / pnpm install can resolve different dependency versions on different machines, leading to non-reproducible builds and subtle bugs.

Roadmap reference: P2 Frontend - missing lockfile

What to do

  1. Decide on a package manager (npm or pnpm — whichever is already in use).
  2. Run npm install or pnpm install locally to generate the lockfile.
  3. Commit package-lock.json or pnpm-lock.yaml to version control.
  4. Update the CI workflow to use npm ci (or pnpm install --frozen-lockfile) instead of npm install.
  5. Add a note to the frontend README section about using the chosen package manager.

Acceptance criteria

  • A lockfile is committed and up-to-date with package.json.
  • CI uses the frozen install command.
  • Two fresh install runs produce identical node_modules dependency trees.
## Context The frontend has no lockfile committed. Without a lockfile, `npm install` / `pnpm install` can resolve different dependency versions on different machines, leading to non-reproducible builds and subtle bugs. Roadmap reference: P2 Frontend - missing lockfile ## What to do 1. Decide on a package manager (npm or pnpm — whichever is already in use). 2. Run `npm install` or `pnpm install` locally to generate the lockfile. 3. Commit `package-lock.json` or `pnpm-lock.yaml` to version control. 4. Update the CI workflow to use `npm ci` (or `pnpm install --frozen-lockfile`) instead of `npm install`. 5. Add a note to the frontend README section about using the chosen package manager. ## Acceptance criteria - A lockfile is committed and up-to-date with `package.json`. - CI uses the frozen install command. - Two fresh `install` runs produce identical `node_modules` dependency trees.
AI-Manager added the P2agent-readysmallfeature labels 2026-03-29 05:23:35 +00:00
AI-Manager commented 2026-03-29 06:03:45 +00:00
Author
Owner
Copy Link
Copy Source

This issue has been resolved. The changes are already merged into main.

package-lock.json committed to frontend/. CI uses frozen lockfile install.

Closing as completed.

This issue has been resolved. The changes are already merged into main. package-lock.json committed to frontend/. CI uses frozen lockfile install. Closing as completed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready feature small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#888
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?