leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

CI: add ruff (Python linting) and tsc --noEmit (TypeScript type checking) to CI pipeline #890

New Issue
Closed
opened 2026-03-29 05:23:52 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-29 05:23:52 +00:00
Owner
Copy Link
Copy Source

Context

There is no linting or type-checking step in CI. Code quality issues and type errors can be merged without detection.

Roadmap reference: P2 CI/CD - linting and type checking

What to do

  1. Add ruff to requirements.txt (or requirements-dev.txt).
  2. Add a lint job in build.yaml that runs ruff check . on the backend source.
  3. Add a typecheck step in the same or separate job that runs tsc --noEmit in the frontend/ directory.
  4. Both steps should fail the pipeline on errors.
  5. Add a ruff.toml or [tool.ruff] config in pyproject.toml with sensible defaults.

Acceptance criteria

  • A ruff violation in backend code causes CI to fail.
  • A TypeScript type error causes CI to fail.
  • Both checks run on every push and PR.
  • Existing codebase passes both checks (fix any pre-existing violations as part of this issue).
## Context There is no linting or type-checking step in CI. Code quality issues and type errors can be merged without detection. Roadmap reference: P2 CI/CD - linting and type checking ## What to do 1. Add `ruff` to `requirements.txt` (or `requirements-dev.txt`). 2. Add a `lint` job in `build.yaml` that runs `ruff check .` on the backend source. 3. Add a `typecheck` step in the same or separate job that runs `tsc --noEmit` in the `frontend/` directory. 4. Both steps should fail the pipeline on errors. 5. Add a `ruff.toml` or `[tool.ruff]` config in `pyproject.toml` with sensible defaults. ## Acceptance criteria - A `ruff` violation in backend code causes CI to fail. - A TypeScript type error causes CI to fail. - Both checks run on every push and PR. - Existing codebase passes both checks (fix any pre-existing violations as part of this issue).
AI-Manager added the P2agent-readymediuminfra labels 2026-03-29 05:23:52 +00:00
AI-Manager commented 2026-03-29 06:03:09 +00:00
Author
Owner
Copy Link
Copy Source

This issue has been resolved. The changes are already merged into main.

ruff linting and tsc --noEmit added to CI pipeline in both build.yaml and test.yaml. ruff.toml config present.

Closing as completed.

This issue has been resolved. The changes are already merged into main. ruff linting and tsc --noEmit added to CI pipeline in both build.yaml and test.yaml. ruff.toml config present. Closing as completed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready infra medium
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#890
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?