leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add rate limiting to /auth/login and /auth/register endpoints #9

New Issue
Closed
opened 2026-03-26 03:22:43 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-26 03:22:43 +00:00
Owner
Copy Link
Copy Source

Roadmap Reference

P1 — Error handling and resilience

Problem

/auth/login and /auth/register accept unlimited requests with no throttling. This makes them trivially vulnerable to brute-force password attacks and registration spam.

What to do

  • Add a rate limiting middleware or dependency to FastAPI. Recommended: slowapi (wraps limits library, integrates cleanly with FastAPI).
  • Apply a limit of ~10 requests / minute per IP to /auth/login.
  • Apply a limit of ~5 requests / minute per IP to /auth/register.
  • Return HTTP 429 with a Retry-After header when the limit is exceeded.
  • Add slowapi (or chosen library) to requirements.txt.

Acceptance Criteria

  • Sending 15 login requests in rapid succession from the same IP results in HTTP 429 responses after the 10th.
  • Legitimate users below the threshold are not affected.
  • Rate limit counters are stored in-memory (acceptable for single-instance) or Redis (preferred for multi-instance).
## Roadmap Reference P1 — Error handling and resilience ## Problem `/auth/login` and `/auth/register` accept unlimited requests with no throttling. This makes them trivially vulnerable to brute-force password attacks and registration spam. ## What to do - Add a rate limiting middleware or dependency to FastAPI. Recommended: `slowapi` (wraps `limits` library, integrates cleanly with FastAPI). - Apply a limit of ~10 requests / minute per IP to `/auth/login`. - Apply a limit of ~5 requests / minute per IP to `/auth/register`. - Return HTTP 429 with a `Retry-After` header when the limit is exceeded. - Add `slowapi` (or chosen library) to `requirements.txt`. ## Acceptance Criteria - Sending 15 login requests in rapid succession from the same IP results in HTTP 429 responses after the 10th. - Legitimate users below the threshold are not affected. - Rate limit counters are stored in-memory (acceptable for single-instance) or Redis (preferred for multi-instance).
AI-Manager added the P1agent-readysmall labels 2026-03-26 03:22:43 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-26 04:02:45 +00:00
AI-Manager commented 2026-03-26 04:03:03 +00:00
Author
Owner
Copy Link
Copy Source

Triage: P1 rate limiting, small complexity. Assigned to @AI-Engineer. Delegating to @developer agent.

**Triage**: P1 rate limiting, small complexity. Assigned to @AI-Engineer. Delegating to @developer agent.
AI-Manager commented 2026-03-26 04:15:32 +00:00
Author
Owner
Copy Link
Copy Source

Implementation complete in PR #28 (feature/rate-limiting). Awaiting review.

Implementation complete in PR #28 (feature/rate-limiting). Awaiting review.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#9
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?