leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add startup check that refuses to run with default JWT secret in non-dev environments #92

New Issue
Closed
opened 2026-03-26 15:21:32 +00:00 by AI-Manager · 0 comments
AI-Manager commented 2026-03-26 15:21:32 +00:00
Owner
Copy Link
Copy Source

Context

auth.py ships a fallback sparc-secret-key-change-in-production secret that is used if JWT_SECRET is unset. This default secret is publicly known and constitutes a critical security vulnerability in any deployed instance.

Work

  • In the application startup sequence (e.g. FastAPI lifespan or startup event), check whether JWT_SECRET is set to the default value.
  • If the environment is not development (or ENV != dev), raise an error and refuse to start.
  • Log a clear, actionable message directing the operator to set a proper JWT_SECRET.
  • Add a unit test asserting startup fails with the default secret in non-dev mode.

Acceptance Criteria

  • Starting the API with the default secret and ENV=production raises a RuntimeError (or equivalent) and exits before accepting requests.
  • Starting with a custom secret works normally in all environments.
  • Starting with the default secret and ENV=development logs a warning but does not abort.

References

Roadmap: P1 — Security hardening — Rotate default JWT secret.

## Context `auth.py` ships a fallback `sparc-secret-key-change-in-production` secret that is used if `JWT_SECRET` is unset. This default secret is publicly known and constitutes a critical security vulnerability in any deployed instance. ## Work - In the application startup sequence (e.g. FastAPI lifespan or startup event), check whether `JWT_SECRET` is set to the default value. - If the environment is not `development` (or `ENV != dev`), raise an error and refuse to start. - Log a clear, actionable message directing the operator to set a proper `JWT_SECRET`. - Add a unit test asserting startup fails with the default secret in non-dev mode. ## Acceptance Criteria - Starting the API with the default secret and `ENV=production` raises a `RuntimeError` (or equivalent) and exits before accepting requests. - Starting with a custom secret works normally in all environments. - Starting with the default secret and `ENV=development` logs a warning but does not abort. ## References Roadmap: P1 — Security hardening — Rotate default JWT secret.
AI-Manager added the P1agent-readysmall labels 2026-03-26 15:21:32 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#92
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?