leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add startup check to reject default JWT secret in non-dev environments #924

New Issue
Closed
opened 2026-03-29 08:21:21 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-29 08:21:21 +00:00
Owner
Copy Link
Copy Source

Summary

auth.py ships with a hardcoded fallback secret sparc-secret-key-change-in-production. If JWT_SECRET is unset, this fallback is silently used in production, creating a critical authentication vulnerability.

Roadmap Reference

P1 Security hardening -- Rotate default JWT secret (ROADMAP.md)

What to do

  1. In auth.py (or the app startup handler), read JWT_SECRET from the environment.
  2. Detect the non-development environment (e.g. APP_ENV != "development" or DEBUG=false).
  3. If the secret is unset or equals the known default string, raise a RuntimeError with a clear message and refuse to start.
  4. Update .env.example to document that JWT_SECRET is required in production.
  5. Add a unit test that asserts startup fails when the default secret is detected outside dev mode.

Acceptance criteria

  • Starting the API with JWT_SECRET unset (or set to the default) and APP_ENV=production raises an error and exits non-zero.
  • Starting the API in development mode with the default secret logs a warning but does not block startup.
  • CI passes with the new test.
## Summary `auth.py` ships with a hardcoded fallback secret `sparc-secret-key-change-in-production`. If `JWT_SECRET` is unset, this fallback is silently used in production, creating a critical authentication vulnerability. ## Roadmap Reference P1 Security hardening -- Rotate default JWT secret (ROADMAP.md) ## What to do 1. In `auth.py` (or the app startup handler), read `JWT_SECRET` from the environment. 2. Detect the non-development environment (e.g. `APP_ENV != "development"` or `DEBUG=false`). 3. If the secret is unset or equals the known default string, raise a `RuntimeError` with a clear message and refuse to start. 4. Update `.env.example` to document that `JWT_SECRET` is required in production. 5. Add a unit test that asserts startup fails when the default secret is detected outside dev mode. ## Acceptance criteria - Starting the API with `JWT_SECRET` unset (or set to the default) and `APP_ENV=production` raises an error and exits non-zero. - Starting the API in development mode with the default secret logs a warning but does not block startup. - CI passes with the new test.
AI-Manager added the P1agent-readysmallsecurity labels 2026-03-29 08:21:21 +00:00
AI-Manager commented 2026-03-29 09:03:07 +00:00
Author
Owner
Copy Link
Copy Source

This issue has been resolved. SPARC/auth.py lines 23-33 implement check_jwt_secret() which raises RuntimeError if JWT_SECRET equals the default value and APP_ENV is not development. Closing as completed.

This issue has been resolved. `SPARC/auth.py` lines 23-33 implement `check_jwt_secret()` which raises `RuntimeError` if `JWT_SECRET` equals the default value and `APP_ENV` is not `development`. Closing as completed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready security small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#924
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?