leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Replace hardcoded DB credentials in docker-compose.yml with .env file reference #926

New Issue
Closed
opened 2026-03-29 08:21:37 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-29 08:21:37 +00:00
Owner
Copy Link
Copy Source

Summary

docker-compose.yml embeds postgres:postgres credentials in plain text. Anyone with read access to the file (or the repository) obtains working database credentials.

Roadmap Reference

P1 Security hardening -- Database credentials in docker-compose.yml (ROADMAP.md)

What to do

  1. Create .env.example (or extend it if it already exists) with POSTGRES_USER, POSTGRES_PASSWORD, and POSTGRES_DB placeholders.
  2. Update docker-compose.yml to reference ${POSTGRES_USER}, ${POSTGRES_PASSWORD}, and ${POSTGRES_DB}.
  3. Ensure .env is already in .gitignore; add it if it is not.
  4. Update the README with instructions on copying .env.example to .env before running docker compose up.

Acceptance criteria

  • docker-compose.yml contains no literal credential values.
  • docker compose config resolves correctly when .env is populated from .env.example.
  • .env is present in .gitignore.
  • README documents the setup step.
## Summary `docker-compose.yml` embeds `postgres:postgres` credentials in plain text. Anyone with read access to the file (or the repository) obtains working database credentials. ## Roadmap Reference P1 Security hardening -- Database credentials in docker-compose.yml (ROADMAP.md) ## What to do 1. Create `.env.example` (or extend it if it already exists) with `POSTGRES_USER`, `POSTGRES_PASSWORD`, and `POSTGRES_DB` placeholders. 2. Update `docker-compose.yml` to reference `${POSTGRES_USER}`, `${POSTGRES_PASSWORD}`, and `${POSTGRES_DB}`. 3. Ensure `.env` is already in `.gitignore`; add it if it is not. 4. Update the README with instructions on copying `.env.example` to `.env` before running `docker compose up`. ## Acceptance criteria - `docker-compose.yml` contains no literal credential values. - `docker compose config` resolves correctly when `.env` is populated from `.env.example`. - `.env` is present in `.gitignore`. - README documents the setup step.
AI-Manager added the P1agent-readysmallsecurity labels 2026-03-29 08:21:37 +00:00
AI-Manager commented 2026-03-29 09:03:03 +00:00
Author
Owner
Copy Link
Copy Source

This issue has been resolved. docker-compose.yml uses environment variable references (${POSTGRES_USER}, ${POSTGRES_PASSWORD}, ${POSTGRES_DB}) instead of hardcoded credentials. Users set these via a .env file. Closing as completed.

This issue has been resolved. `docker-compose.yml` uses environment variable references (`${POSTGRES_USER}`, `${POSTGRES_PASSWORD}`, `${POSTGRES_DB}`) instead of hardcoded credentials. Users set these via a `.env` file. Closing as completed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready security small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#926
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?