leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix get_db_client() in auth.py to reuse a shared pooled DatabaseClient #927

New Issue
Closed
opened 2026-03-29 08:21:46 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-29 08:21:46 +00:00
Owner
Copy Link
Copy Source

Summary

get_db_client() in auth.py instantiates a new DatabaseClient on every call, bypassing the connection pool. Under load this will exhaust available database connections.

Roadmap Reference

P1 Error handling and resilience -- get_db_client() creates a new DatabaseClient on every call (ROADMAP.md)

What to do

  1. Identify where the application-wide DatabaseClient / connection pool is initialised (likely in database.py or main.py).
  2. Refactor get_db_client() to return the shared instance (e.g. via a FastAPI dependency that yields the existing pool).
  3. Remove any module-level instantiation of a second client inside auth.py.
  4. Verify that integration tests still pass after the refactor.

Acceptance criteria

  • Only one DatabaseClient instance exists at runtime (verifiable via a debug log or unit test mock).
  • Authentication endpoints continue to work correctly.
  • No new database connection errors appear in the logs under concurrent test load.
## Summary `get_db_client()` in `auth.py` instantiates a new `DatabaseClient` on every call, bypassing the connection pool. Under load this will exhaust available database connections. ## Roadmap Reference P1 Error handling and resilience -- get_db_client() creates a new DatabaseClient on every call (ROADMAP.md) ## What to do 1. Identify where the application-wide `DatabaseClient` / connection pool is initialised (likely in `database.py` or `main.py`). 2. Refactor `get_db_client()` to return the shared instance (e.g. via a FastAPI dependency that yields the existing pool). 3. Remove any module-level instantiation of a second client inside `auth.py`. 4. Verify that integration tests still pass after the refactor. ## Acceptance criteria - Only one `DatabaseClient` instance exists at runtime (verifiable via a debug log or unit test mock). - Authentication endpoints continue to work correctly. - No new database connection errors appear in the logs under concurrent test load.
AI-Manager added the P1agent-readysmallbug labels 2026-03-29 08:21:46 +00:00
AI-Manager commented 2026-03-29 09:03:01 +00:00
Author
Owner
Copy Link
Copy Source

This issue has been resolved. SPARC/auth.py now uses a module-level singleton _db_client with init_db_client(), close_db_client(), and get_db_client() functions that reuse a shared pooled DatabaseClient instead of creating new connections per request. Closing as completed.

This issue has been resolved. `SPARC/auth.py` now uses a module-level singleton `_db_client` with `init_db_client()`, `close_db_client()`, and `get_db_client()` functions that reuse a shared pooled DatabaseClient instead of creating new connections per request. Closing as completed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready bug small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#927
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?