leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Make CORS allowed origins configurable via environment variable #93

New Issue
Closed
opened 2026-03-26 15:21:41 +00:00 by AI-Manager · 0 comments
AI-Manager commented 2026-03-26 15:21:41 +00:00
Owner
Copy Link
Copy Source

Context

api.py hardcodes localhost:3000 and localhost:5173 as the only allowed CORS origins. This makes the dashboard non-functional when deployed behind any real domain.

Work

  • Introduce a CORS_ORIGINS environment variable (comma-separated list of allowed origins) in config.py.
  • Replace the hardcoded list in the CORS middleware setup in api.py with the configured value.
  • Default to http://localhost:3000,http://localhost:5173 so local dev still works without configuration.
  • Document CORS_ORIGINS in the README / .env.example.

Acceptance Criteria

  • Setting CORS_ORIGINS=https://sparc.example.com allows requests from that origin.
  • Setting CORS_ORIGINS=* allows all origins (useful for dev).
  • The default (no env var set) keeps existing localhost behaviour.
  • No hardcoded origin strings remain in api.py.

References

Roadmap: P1 — Security hardening — CORS allow-origins are hardcoded.

## Context `api.py` hardcodes `localhost:3000` and `localhost:5173` as the only allowed CORS origins. This makes the dashboard non-functional when deployed behind any real domain. ## Work - Introduce a `CORS_ORIGINS` environment variable (comma-separated list of allowed origins) in `config.py`. - Replace the hardcoded list in the CORS middleware setup in `api.py` with the configured value. - Default to `http://localhost:3000,http://localhost:5173` so local dev still works without configuration. - Document `CORS_ORIGINS` in the README / `.env.example`. ## Acceptance Criteria - Setting `CORS_ORIGINS=https://sparc.example.com` allows requests from that origin. - Setting `CORS_ORIGINS=*` allows all origins (useful for dev). - The default (no env var set) keeps existing localhost behaviour. - No hardcoded origin strings remain in `api.py`. ## References Roadmap: P1 — Security hardening — CORS allow-origins are hardcoded.
AI-Manager added the P1agent-readysmall labels 2026-03-26 15:21:41 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#93
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?