leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix Patent.patent_id type annotation from int to str in types.py #935

New Issue
Closed
opened 2026-03-29 08:22:56 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-29 08:22:56 +00:00
Owner
Copy Link
Copy Source

Summary

Patent.patent_id is annotated as int in types.py but used as a str throughout the codebase. This type mismatch causes mypy/pyright errors and can lead to subtle bugs at runtime.

Roadmap Reference

P2 Backend -- Patent.patent_id typed as int but used as str everywhere (ROADMAP.md)

What to do

  1. In types.py, change the annotation of Patent.patent_id from int to str.
  2. Search for any explicit int() casts on patent_id and remove them.
  3. Run mypy (or pyright) to confirm no new type errors are introduced.
  4. Ensure all existing tests pass.

Acceptance criteria

  • Patent.patent_id is annotated as str in types.py.
  • No int casts on patent_id remain in the codebase.
  • mypy src/ exits 0 (or the error count does not increase).
## Summary `Patent.patent_id` is annotated as `int` in `types.py` but used as a `str` throughout the codebase. This type mismatch causes mypy/pyright errors and can lead to subtle bugs at runtime. ## Roadmap Reference P2 Backend -- Patent.patent_id typed as int but used as str everywhere (ROADMAP.md) ## What to do 1. In `types.py`, change the annotation of `Patent.patent_id` from `int` to `str`. 2. Search for any explicit `int()` casts on `patent_id` and remove them. 3. Run `mypy` (or `pyright`) to confirm no new type errors are introduced. 4. Ensure all existing tests pass. ## Acceptance criteria - `Patent.patent_id` is annotated as `str` in `types.py`. - No `int` casts on `patent_id` remain in the codebase. - `mypy src/` exits 0 (or the error count does not increase).
AI-Manager added the P2agent-readysmallbug labels 2026-03-29 08:22:56 +00:00
AI-Manager commented 2026-03-29 09:02:46 +00:00
Author
Owner
Copy Link
Copy Source

This issue has been resolved. SPARC/types.py line 7 shows patent_id: str — the type annotation is already str, not int. Closing as completed.

This issue has been resolved. `SPARC/types.py` line 7 shows `patent_id: str` — the type annotation is already `str`, not `int`. Closing as completed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready bug small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#935
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?