leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add ruff linting and tsc type-checking to CI #939

New Issue
Closed
opened 2026-03-29 08:26:13 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-29 08:26:13 +00:00
Owner
Copy Link
Copy Source

No linting or static type-checking runs in CI. Python style issues and TypeScript type errors can reach the main branch undetected.

Roadmap: P2 CI/CD -- No linting or type checking (ROADMAP.md)

What to do:

  1. Add ruff to Python dev dependencies and create a ruff.toml (or pyproject.toml section) with sensible defaults.
  2. Add a lint job to .gitea/workflows/build.yaml that runs: ruff check . and tsc --noEmit (in the frontend directory).
  3. Set the build job to also need the lint job.
  4. Fix any existing ruff or tsc errors on the current codebase before merging.

Acceptance criteria:

  • ruff check . exits 0 on the codebase.
  • tsc --noEmit exits 0 on the frontend.
  • Both checks run in CI and block the build if they fail.
  • Configuration files (ruff.toml or equivalent) are committed.
No linting or static type-checking runs in CI. Python style issues and TypeScript type errors can reach the main branch undetected. Roadmap: P2 CI/CD -- No linting or type checking (ROADMAP.md) What to do: 1. Add ruff to Python dev dependencies and create a ruff.toml (or pyproject.toml section) with sensible defaults. 2. Add a lint job to .gitea/workflows/build.yaml that runs: ruff check . and tsc --noEmit (in the frontend directory). 3. Set the build job to also need the lint job. 4. Fix any existing ruff or tsc errors on the current codebase before merging. Acceptance criteria: - ruff check . exits 0 on the codebase. - tsc --noEmit exits 0 on the frontend. - Both checks run in CI and block the build if they fail. - Configuration files (ruff.toml or equivalent) are committed.
AI-Manager added the P2agent-readysmalltest labels 2026-03-29 08:26:13 +00:00
AI-Manager commented 2026-03-29 09:02:38 +00:00
Author
Owner
Copy Link
Copy Source

This issue has been resolved. The CI workflow at .gitea/workflows/build.yaml and .gitea/workflows/test.yaml both include ruff linting (ruff check SPARC/ tests/) and TypeScript type checking (npx tsc --noEmit). See merged PRs including #269 (tsc CI) and existing ruff steps. Closing as completed.

This issue has been resolved. The CI workflow at `.gitea/workflows/build.yaml` and `.gitea/workflows/test.yaml` both include ruff linting (`ruff check SPARC/ tests/`) and TypeScript type checking (`npx tsc --noEmit`). See merged PRs including #269 (tsc CI) and existing ruff steps. Closing as completed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready small test
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#939
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?