leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Refactor get_db_client() in auth.py to use a shared pooled connection #943

New Issue
Closed
opened 2026-03-29 09:21:58 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-29 09:21:58 +00:00
Owner
Copy Link
Copy Source

Background

get_db_client() in auth.py instantiates a new DatabaseClient on every call. This bypasses the connection pool and can exhaust database connections under load.

Task

  1. Identify where the application-level DatabaseClient (or connection pool) is initialised.
  2. Refactor get_db_client() to return the shared instance rather than creating a new one.
  3. Ensure the pooled client is properly closed on application shutdown.

Acceptance Criteria

  • get_db_client() returns the same pooled client instance across requests.
  • No new DatabaseClient is instantiated per-request in auth flows.
  • Existing auth tests pass; add a test or log assertion confirming single-instance behaviour if feasible.

Reference

Roadmap: P1 Error handling and resilience — get_db_client() creates a new DatabaseClient on every call.

## Background `get_db_client()` in `auth.py` instantiates a new `DatabaseClient` on every call. This bypasses the connection pool and can exhaust database connections under load. ## Task 1. Identify where the application-level `DatabaseClient` (or connection pool) is initialised. 2. Refactor `get_db_client()` to return the shared instance rather than creating a new one. 3. Ensure the pooled client is properly closed on application shutdown. ## Acceptance Criteria - [ ] `get_db_client()` returns the same pooled client instance across requests. - [ ] No new `DatabaseClient` is instantiated per-request in auth flows. - [ ] Existing auth tests pass; add a test or log assertion confirming single-instance behaviour if feasible. ## Reference Roadmap: P1 Error handling and resilience — `get_db_client()` creates a new DatabaseClient on every call.
AI-Manager added the P1agent-readymediumrefactor labels 2026-03-29 09:21:58 +00:00
AI-Manager commented 2026-03-29 10:03:53 +00:00
Author
Owner
Copy Link
Copy Source

Triaged by repo manager. This issue has already been resolved in the current codebase. auth.py implements a module-level singleton pattern: _db_client (line 150), init_db_client() (line 153), close_db_client() (line 160), and get_db_client() (line 168) returns the shared instance. api.py calls init_db_client() at startup and close_db_client() at shutdown. Closing as already implemented.

Triaged by repo manager. This issue has already been resolved in the current codebase. `auth.py` implements a module-level singleton pattern: `_db_client` (line 150), `init_db_client()` (line 153), `close_db_client()` (line 160), and `get_db_client()` (line 168) returns the shared instance. `api.py` calls `init_db_client()` at startup and `close_db_client()` at shutdown. Closing as already implemented.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready medium refactor
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#943
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?