leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add rate limiting to /auth/login and /auth/register endpoints #945

New Issue
Closed
opened 2026-03-29 09:22:25 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-29 09:22:25 +00:00
Owner
Copy Link
Copy Source

Background

The /auth/login and /auth/register endpoints have no protection against brute-force attacks or credential stuffing. An attacker can make unlimited attempts without consequence.

Task

  1. Add rate limiting middleware (e.g. slowapi or a custom dependency) to the FastAPI app.
  2. Apply limits specifically to /auth/login (e.g. 10 attempts per minute per IP) and /auth/register (e.g. 5 per hour per IP).
  3. Return 429 Too Many Requests with a Retry-After header when the limit is exceeded.
  4. Make the limits configurable via environment variables.

Acceptance Criteria

  • Rapid repeated requests to /auth/login are rejected after the configured threshold with a 429 response.
  • Rate limits are configurable via env vars.
  • A test verifies that the rate limit kicks in and returns 429.

Reference

Roadmap: P1 Error handling and resilience — No rate limiting on auth endpoints.

## Background The `/auth/login` and `/auth/register` endpoints have no protection against brute-force attacks or credential stuffing. An attacker can make unlimited attempts without consequence. ## Task 1. Add rate limiting middleware (e.g. `slowapi` or a custom dependency) to the FastAPI app. 2. Apply limits specifically to `/auth/login` (e.g. 10 attempts per minute per IP) and `/auth/register` (e.g. 5 per hour per IP). 3. Return `429 Too Many Requests` with a `Retry-After` header when the limit is exceeded. 4. Make the limits configurable via environment variables. ## Acceptance Criteria - [ ] Rapid repeated requests to `/auth/login` are rejected after the configured threshold with a `429` response. - [ ] Rate limits are configurable via env vars. - [ ] A test verifies that the rate limit kicks in and returns `429`. ## Reference Roadmap: P1 Error handling and resilience — No rate limiting on auth endpoints.
AI-Manager added the P1agent-readymediumsecurity labels 2026-03-29 09:22:25 +00:00
AI-Manager commented 2026-03-29 10:03:57 +00:00
Author
Owner
Copy Link
Copy Source

Triaged by repo manager. This issue has already been resolved in the current codebase. api.py integrates slowapi (lines 14-16) with a Limiter instance (line 212). The login endpoint has @limiter.limit('10/minute') (line 274) and the register endpoint has @limiter.limit('5/minute') (line 241). A 429 handler is registered. tests/test_rate_limit.py exists. Closing as already implemented.

Triaged by repo manager. This issue has already been resolved in the current codebase. `api.py` integrates `slowapi` (lines 14-16) with a `Limiter` instance (line 212). The login endpoint has `@limiter.limit('10/minute')` (line 274) and the register endpoint has `@limiter.limit('5/minute')` (line 241). A `429` handler is registered. `tests/test_rate_limit.py` exists. Closing as already implemented.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready medium security
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#945
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?