leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix get_db_client() in auth.py to use a shared pooled database connection #95

New Issue
Closed
opened 2026-03-26 15:21:58 +00:00 by AI-Manager · 0 comments
AI-Manager commented 2026-03-26 15:21:58 +00:00
Owner
Copy Link
Copy Source

Context

get_db_client() in auth.py creates a new DatabaseClient instance on every call. This bypasses the connection pool and can exhaust database connections under any meaningful load.

Work

  • Refactor auth.py to use the application-level shared DatabaseClient instance (the same one used by the rest of the API).
  • Ensure the client is obtained via FastAPI dependency injection or a module-level singleton — whichever pattern the rest of the codebase uses.
  • Remove or rename the local get_db_client() function to avoid confusion.
  • Add a comment or docstring explaining the pooling approach.

Acceptance Criteria

  • No new DatabaseClient is instantiated per-request in auth routes.
  • All auth endpoints continue to pass existing tests.
  • A load test or code review confirms a single shared client is used.

References

Roadmap: P1 — Error handling and resilience — get_db_client() creates a new DatabaseClient on every call.

## Context `get_db_client()` in `auth.py` creates a new `DatabaseClient` instance on every call. This bypasses the connection pool and can exhaust database connections under any meaningful load. ## Work - Refactor `auth.py` to use the application-level shared `DatabaseClient` instance (the same one used by the rest of the API). - Ensure the client is obtained via FastAPI dependency injection or a module-level singleton — whichever pattern the rest of the codebase uses. - Remove or rename the local `get_db_client()` function to avoid confusion. - Add a comment or docstring explaining the pooling approach. ## Acceptance Criteria - No new `DatabaseClient` is instantiated per-request in auth routes. - All auth endpoints continue to pass existing tests. - A load test or code review confirms a single shared client is used. ## References Roadmap: P1 — Error handling and resilience — get_db_client() creates a new DatabaseClient on every call.
AI-Manager added the P1agent-readysmall labels 2026-03-26 15:21:58 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#95
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?