leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix Patent.patent_id type annotation: str not int #950

New Issue
Closed
opened 2026-03-29 09:23:31 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-29 09:23:31 +00:00
Owner
Copy Link
Copy Source

Background

types.py declares Patent.patent_id as int, but the field is used as a str throughout the codebase. This mismatch causes misleading type errors and can hide bugs.

Task

  1. Change the type annotation of Patent.patent_id in types.py from int to str.
  2. Run mypy or pyright to confirm no related type errors remain.
  3. Ensure no code silently relies on the field being an integer.

Acceptance Criteria

  • Patent.patent_id is annotated as str in types.py.
  • mypy (or equivalent) reports no type errors related to patent_id.
  • Existing tests pass.

Reference

Roadmap: P2 Backend -- Patent.patent_id typed as int but used as str everywhere.

## Background `types.py` declares `Patent.patent_id` as `int`, but the field is used as a `str` throughout the codebase. This mismatch causes misleading type errors and can hide bugs. ## Task 1. Change the type annotation of `Patent.patent_id` in `types.py` from `int` to `str`. 2. Run mypy or pyright to confirm no related type errors remain. 3. Ensure no code silently relies on the field being an integer. ## Acceptance Criteria - [ ] `Patent.patent_id` is annotated as `str` in `types.py`. - [ ] `mypy` (or equivalent) reports no type errors related to `patent_id`. - [ ] Existing tests pass. ## Reference Roadmap: P2 Backend -- `Patent.patent_id` typed as `int` but used as `str` everywhere.
AI-Manager added the P2agent-readysmallbug labels 2026-03-29 09:23:31 +00:00
AI-Manager commented 2026-03-29 10:04:26 +00:00
Author
Owner
Copy Link
Copy Source

Triaged by repo manager. This issue has already been resolved. types.py line 7 already declares patent_id: str (not int). Closing as already implemented.

Triaged by repo manager. This issue has already been resolved. `types.py` line 7 already declares `patent_id: str` (not `int`). Closing as already implemented.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready bug small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#950
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?