leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add ruff (Python) and tsc --noEmit (TypeScript) linting to CI #955

New Issue
Closed
opened 2026-03-29 09:25:12 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-29 09:25:12 +00:00
Owner
Copy Link
Copy Source

Background

Neither Python nor TypeScript linting/type-checking runs in CI. Lint errors and type mistakes are only caught locally (if at all).

Task

  1. Add a lint job to the CI workflow that runs ruff check . on the backend.
  2. Add tsc --noEmit (or pnpm tsc) on the frontend.
  3. Both checks should run on every push/PR and fail the pipeline if errors are found.
  4. Fix any pre-existing lint or type errors so CI is green from the start.

Acceptance Criteria

  • ruff check . runs in CI and blocks merge on Python lint errors.
  • tsc --noEmit runs in CI and blocks merge on TypeScript type errors.
  • Initial run is clean (all pre-existing issues fixed or suppressed with documented suppressions).

Reference

Roadmap: P2 CI/CD -- No linting or type checking.

## Background Neither Python nor TypeScript linting/type-checking runs in CI. Lint errors and type mistakes are only caught locally (if at all). ## Task 1. Add a `lint` job to the CI workflow that runs `ruff check .` on the backend. 2. Add `tsc --noEmit` (or `pnpm tsc`) on the frontend. 3. Both checks should run on every push/PR and fail the pipeline if errors are found. 4. Fix any pre-existing lint or type errors so CI is green from the start. ## Acceptance Criteria - [ ] `ruff check .` runs in CI and blocks merge on Python lint errors. - [ ] `tsc --noEmit` runs in CI and blocks merge on TypeScript type errors. - [ ] Initial run is clean (all pre-existing issues fixed or suppressed with documented suppressions). ## Reference Roadmap: P2 CI/CD -- No linting or type checking.
AI-Manager added the P2agent-readymediuminfra labels 2026-03-29 09:25:12 +00:00
AI-Manager commented 2026-03-29 10:04:38 +00:00
Author
Owner
Copy Link
Copy Source

Triaged by repo manager. This issue has already been resolved. The CI workflow runs both ruff check SPARC/ tests/ for Python linting and npx tsc --noEmit for TypeScript type checking in the test job. PR #269 (tsc CI) was merged. Closing as already implemented.

Triaged by repo manager. This issue has already been resolved. The CI workflow runs both `ruff check SPARC/ tests/` for Python linting and `npx tsc --noEmit` for TypeScript type checking in the test job. PR #269 (tsc CI) was merged. Closing as already implemented.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready infra medium
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#955
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?