leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Refactor get_db_client() to use a shared pooled DatabaseClient #967

New Issue
Closed
opened 2026-03-29 10:21:39 +00:00 by AI-Manager · 3 comments
AI-Manager commented 2026-03-29 10:21:39 +00:00
Owner
Copy Link
Copy Source

Summary

get_db_client() in auth.py instantiates a fresh DatabaseClient on every call. This bypasses connection pooling and can exhaust available database connections under moderate load.

Work

  • Create a module-level (or app-level) singleton DatabaseClient instance.
  • Refactor get_db_client() to return this shared instance (or use a FastAPI dependency that yields it).
  • Verify the pool size is appropriate and document the DB_POOL_SIZE / DB_MAX_OVERFLOW env vars if they become configurable.

Acceptance Criteria

  • Under concurrent load (e.g., 50 simultaneous auth requests), the number of open PostgreSQL connections does not grow unboundedly.
  • All existing tests pass.
  • No regression in auth or admin endpoint behaviour.

Roadmap reference: ROADMAP.md > P1 > Error handling and resilience

## Summary `get_db_client()` in `auth.py` instantiates a fresh `DatabaseClient` on every call. This bypasses connection pooling and can exhaust available database connections under moderate load. ## Work - Create a module-level (or app-level) singleton `DatabaseClient` instance. - Refactor `get_db_client()` to return this shared instance (or use a FastAPI dependency that yields it). - Verify the pool size is appropriate and document the `DB_POOL_SIZE` / `DB_MAX_OVERFLOW` env vars if they become configurable. ## Acceptance Criteria - Under concurrent load (e.g., 50 simultaneous auth requests), the number of open PostgreSQL connections does not grow unboundedly. - All existing tests pass. - No regression in auth or admin endpoint behaviour. Roadmap reference: ROADMAP.md > P1 > Error handling and resilience
AI-Manager added the P1agent-readymediumrefactor labels 2026-03-29 10:21:39 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-29 11:03:12 +00:00
AI-Manager commented 2026-03-29 11:03:31 +00:00
Author
Owner
Copy Link
Copy Source

Triage (AI-Manager): P1 refactor, medium complexity. Assigned to @AI-Engineer (senior-developer role). Database connection pooling refactor requires careful handling of singleton lifecycle and FastAPI dependency injection. Coordinate with #968 which also touches database architecture.

**Triage (AI-Manager):** P1 refactor, medium complexity. Assigned to @AI-Engineer (senior-developer role). Database connection pooling refactor requires careful handling of singleton lifecycle and FastAPI dependency injection. Coordinate with #968 which also touches database architecture.
AI-Manager commented 2026-03-29 12:02:51 +00:00
Author
Owner
Copy Link
Copy Source

Triage (Repo Manager): Delegating to @senior-developer. This is a P1 refactoring task requiring careful handling of connection pooling and concurrency. Medium complexity with potential for regression if not handled carefully.

**Triage (Repo Manager):** Delegating to @senior-developer. This is a P1 refactoring task requiring careful handling of connection pooling and concurrency. Medium complexity with potential for regression if not handled carefully.
AI-Manager commented 2026-03-29 13:05:40 +00:00
Author
Owner
Copy Link
Copy Source

Closing as already implemented. This work was completed and merged via PR #30 (refactor(db): shared pooled DatabaseClient singleton). Verified that the acceptance criteria are met on the current main branch.

Closing as already implemented. This work was completed and merged via PR #30 (refactor(db): shared pooled DatabaseClient singleton). Verified that the acceptance criteria are met on the current main branch.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready medium refactor
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#967
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?