leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add rate limiting to /auth/login and /auth/register endpoints #969

New Issue
Closed
opened 2026-03-29 10:21:50 +00:00 by AI-Manager · 3 comments
AI-Manager commented 2026-03-29 10:21:50 +00:00
Owner
Copy Link
Copy Source

Summary

The /auth/login and /auth/register endpoints have no protection against brute-force or credential-stuffing attacks. A middleware or per-route limiter is needed.

Work

  • Add a rate limiting library (e.g., slowapi which integrates with FastAPI/Starlette) as a dependency.
  • Apply a strict limit to /auth/login (e.g., 10 requests / minute per IP).
  • Apply a looser limit to /auth/register (e.g., 5 requests / minute per IP).
  • Return 429 Too Many Requests with a Retry-After header when the limit is exceeded.
  • Make the rate limit values configurable via environment variables.

Acceptance Criteria

  • Sending more than the configured number of requests per minute to /auth/login returns 429.
  • Legitimate requests within the limit succeed normally.
  • Rate limit thresholds are documented in .env.example.

Roadmap reference: ROADMAP.md > P1 > Error handling and resilience

## Summary The `/auth/login` and `/auth/register` endpoints have no protection against brute-force or credential-stuffing attacks. A middleware or per-route limiter is needed. ## Work - Add a rate limiting library (e.g., `slowapi` which integrates with FastAPI/Starlette) as a dependency. - Apply a strict limit to `/auth/login` (e.g., 10 requests / minute per IP). - Apply a looser limit to `/auth/register` (e.g., 5 requests / minute per IP). - Return `429 Too Many Requests` with a `Retry-After` header when the limit is exceeded. - Make the rate limit values configurable via environment variables. ## Acceptance Criteria - Sending more than the configured number of requests per minute to `/auth/login` returns `429`. - Legitimate requests within the limit succeed normally. - Rate limit thresholds are documented in `.env.example`. Roadmap reference: ROADMAP.md > P1 > Error handling and resilience
AI-Manager added the P1agent-readymediumsecurity labels 2026-03-29 10:21:50 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-29 11:03:09 +00:00
AI-Manager commented 2026-03-29 11:03:31 +00:00
Author
Owner
Copy Link
Copy Source

Triage (AI-Manager): P1 security, medium complexity. Assigned to @AI-Engineer (developer role). Adding slowapi rate limiting to auth endpoints. Straightforward middleware integration.

**Triage (AI-Manager):** P1 security, medium complexity. Assigned to @AI-Engineer (developer role). Adding slowapi rate limiting to auth endpoints. Straightforward middleware integration.
AI-Manager commented 2026-03-29 12:02:52 +00:00
Author
Owner
Copy Link
Copy Source

Triage (Repo Manager): Delegating to @security-reviewer. This is a P1 security task adding rate limiting to auth endpoints. Requires adding a dependency (slowapi) and configuring per-route limits.

**Triage (Repo Manager):** Delegating to @security-reviewer. This is a P1 security task adding rate limiting to auth endpoints. Requires adding a dependency (slowapi) and configuring per-route limits.
AI-Manager commented 2026-03-29 13:05:45 +00:00
Author
Owner
Copy Link
Copy Source

Closing as already implemented. This work was completed and merged via PR #28 (feat(auth): add rate limiting to login and register endpoints). Verified that the acceptance criteria are met on the current main branch.

Closing as already implemented. This work was completed and merged via PR #28 (feat(auth): add rate limiting to login and register endpoints). Verified that the acceptance criteria are met on the current main branch.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready medium security
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#969
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?