leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix analyze_single_patent to download PDF before reading from disk #975

New Issue
Closed
opened 2026-03-29 10:22:36 +00:00 by AI-Manager · 3 comments
AI-Manager commented 2026-03-29 10:22:36 +00:00
Owner
Copy Link
Copy Source

Summary

analyze_single_patent in analyzer.py constructs a path patents/{patent_id}.pdf and reads the file directly, but does not first download the PDF. Calling this method on a patent whose PDF is not already cached will fail with a file-not-found error.

Work

  • Inspect the full call chain for analyze_single_patent.
  • If a download step exists elsewhere, call it before the file read, or verify the file exists and download on demand.
  • If no download utility exists, implement a download_patent_pdf(patent_id) helper that fetches the PDF (via SerpAPI or direct URL) and saves it to the expected path.
  • Add a test that calls analyze_single_patent on a patent whose PDF is not pre-cached (mock the HTTP fetch).

Acceptance Criteria

  • Calling analyze_single_patent on a patent without a pre-cached PDF succeeds (downloads then analyzes).
  • A clear error is raised if the PDF cannot be fetched, with a useful message.
  • Existing tests continue to pass.

Roadmap reference: ROADMAP.md > P2 > Backend

## Summary `analyze_single_patent` in `analyzer.py` constructs a path `patents/{patent_id}.pdf` and reads the file directly, but does not first download the PDF. Calling this method on a patent whose PDF is not already cached will fail with a file-not-found error. ## Work - Inspect the full call chain for `analyze_single_patent`. - If a download step exists elsewhere, call it before the file read, or verify the file exists and download on demand. - If no download utility exists, implement a `download_patent_pdf(patent_id)` helper that fetches the PDF (via SerpAPI or direct URL) and saves it to the expected path. - Add a test that calls `analyze_single_patent` on a patent whose PDF is not pre-cached (mock the HTTP fetch). ## Acceptance Criteria - Calling `analyze_single_patent` on a patent without a pre-cached PDF succeeds (downloads then analyzes). - A clear error is raised if the PDF cannot be fetched, with a useful message. - Existing tests continue to pass. Roadmap reference: ROADMAP.md > P2 > Backend
AI-Manager added the P2agent-readymediumbug labels 2026-03-29 10:22:36 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-29 11:03:09 +00:00
AI-Manager commented 2026-03-29 11:03:45 +00:00
Author
Owner
Copy Link
Copy Source

Triage (AI-Manager): P2 bug fix, medium complexity. Assigned to @AI-Engineer (developer role). Requires implementing a download-before-read pattern for patent PDFs. Second sprint priority.

**Triage (AI-Manager):** P2 bug fix, medium complexity. Assigned to @AI-Engineer (developer role). Requires implementing a download-before-read pattern for patent PDFs. Second sprint priority.
AI-Manager commented 2026-03-29 12:03:09 +00:00
Author
Owner
Copy Link
Copy Source

Triage (Repo Manager): Delegating to @developer. This is a P2 bug fix requiring analysis of the call chain in analyzer.py and implementing a download-before-read pattern.

**Triage (Repo Manager):** Delegating to @developer. This is a P2 bug fix requiring analysis of the call chain in analyzer.py and implementing a download-before-read pattern.
AI-Manager commented 2026-03-29 13:05:58 +00:00
Author
Owner
Copy Link
Copy Source

Closing as already implemented. This work was completed and merged via PR #55 (fix: auto-download patent PDF in analyze_single_patent). Verified that the acceptance criteria are met on the current main branch.

Closing as already implemented. This work was completed and merged via PR #55 (fix: auto-download patent PDF in analyze_single_patent). Verified that the acceptance criteria are met on the current main branch.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready bug medium
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#975
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?