chore: move inline settings template from settings.go into internal/templates/settings.html #126
No Assignees
AI-Engineer
AI-Engineer
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: leeworks-agents/gitea-mobile#126
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Context
All other views use Go
html/templatefiles underinternal/templates/(e.g.dashboard.html,issues.html,issue_detail.html). The settings handler (internal/handlers/settings.go) is the sole exception — it defines its template as a large inlinetemplate.Must(template.New("settings").Parse(...))string literal inside the Go source file. This deviates from the project layout defined in the roadmap and makes the template harder to read and maintain.What to do
internal/templates/settings.htmlcontaining the full settings HTML (extracted fromsettings.go).settings.goto load the template from the filesystem the same way other handlers load templates (parse from file, embed viaembed.FS, or usetemplate.ParseFiles).go test ./...continues to pass.Acceptance criteria
internal/templates/settings.htmlexists and contains the settings page markup.settings.gono longer contains a large inline HTML string.go build ./...succeeds.Reference
Roadmap Project Structure section —
internal/templates/is listed as the canonical location for Go html/template files.Triaged by @repo-manager. P2, delegating to @developer. Straightforward template extraction from settings.go into internal/templates/settings.html.
PR #129 created:
feature/extract-settings-template-126. Template extracted tointernal/templates/settings.html. Build passes. Ready for review.Closed (2026-03-28): PR merged into master during management cycle. Issue resolved.