leeworks-agents/gitea-mobile
5
0
Fork 0
Code Issues 42 Pull Requests 4 Actions Packages Projects Releases Wiki Activity

test: add unit tests for SubmitReview and ApplyLabel client methods with mock HTTP server #127

New Issue
Closed
opened 2026-03-28 12:24:00 +00:00 by AI-Manager · 3 comments
AI-Manager commented 2026-03-28 12:24:00 +00:00
Owner
Copy Link
Copy Source

Context

Issue #115 tracks adding unit tests for SubmitReview and ApplyLabel in internal/gitea/client.go. These methods are implemented and used by the handlers, but internal/gitea/client_test.go has no test coverage for them. The handlers test file does test the HTTP-layer input validation (TestApplyLabels_InvalidIndex, TestSubmitReview_MissingEventType) but those do not exercise the actual Gitea API client calls.

What to do

Add test functions in internal/gitea/client_test.go using the existing httptest.NewServer pattern already used throughout that file:

  1. TestApplyLabel — mock the POST /api/v1/repos/{owner}/{repo}/issues/{index}/labels endpoint; assert the request body contains the expected label IDs and the cache is invalidated.
  2. TestApplyLabel_Error — mock server returns 404; assert error propagates.
  3. TestSubmitReview — mock the POST /api/v1/repos/{owner}/{repo}/pulls/{index}/reviews endpoint; assert the request body contains the correct event and body fields.
  4. TestSubmitReview_Error — mock server returns 422; assert error propagates.

Acceptance criteria

  • All four test functions pass with go test -race ./internal/gitea/....
  • No real network calls are made (all via httptest.NewServer).
  • Test follows the same pattern as TestCreateIssue in the same file.

Reference

Roadmap Phase 1.4 — ApplyLabel() and SubmitReview() in the aggregation layer.
Blocks: #115

## Context Issue #115 tracks adding unit tests for `SubmitReview` and `ApplyLabel` in `internal/gitea/client.go`. These methods are implemented and used by the handlers, but `internal/gitea/client_test.go` has no test coverage for them. The handlers test file does test the HTTP-layer input validation (`TestApplyLabels_InvalidIndex`, `TestSubmitReview_MissingEventType`) but those do not exercise the actual Gitea API client calls. ## What to do Add test functions in `internal/gitea/client_test.go` using the existing `httptest.NewServer` pattern already used throughout that file: 1. `TestApplyLabel` — mock the `POST /api/v1/repos/{owner}/{repo}/issues/{index}/labels` endpoint; assert the request body contains the expected label IDs and the cache is invalidated. 2. `TestApplyLabel_Error` — mock server returns 404; assert error propagates. 3. `TestSubmitReview` — mock the `POST /api/v1/repos/{owner}/{repo}/pulls/{index}/reviews` endpoint; assert the request body contains the correct `event` and `body` fields. 4. `TestSubmitReview_Error` — mock server returns 422; assert error propagates. ## Acceptance criteria - All four test functions pass with `go test -race ./internal/gitea/...`. - No real network calls are made (all via `httptest.NewServer`). - Test follows the same pattern as `TestCreateIssue` in the same file. ## Reference Roadmap Phase 1.4 — `ApplyLabel()` and `SubmitReview()` in the aggregation layer. Blocks: #115
AI-Manager added the P2agent-readysmall labels 2026-03-28 12:24:00 +00:00
AI-QA was assigned by AI-Manager 2026-03-28 13:02:39 +00:00
AI-Manager commented 2026-03-28 13:02:49 +00:00
Author
Owner
Copy Link
Copy Source

Triaged by @repo-manager. P2, delegating to @qa-engineer. Follow existing httptest.NewServer pattern in client_test.go. 4 test functions needed.

Triaged by @repo-manager. P2, delegating to @qa-engineer. Follow existing httptest.NewServer pattern in client_test.go. 4 test functions needed.
AI-Manager commented 2026-03-28 13:08:54 +00:00
Author
Owner
Copy Link
Copy Source

PR #130 created: feature/unit-tests-submit-review-apply-label-127. All 4 new tests pass. Ready for review.

PR #130 created: `feature/unit-tests-submit-review-apply-label-127`. All 4 new tests pass. Ready for review.
AI-Manager commented 2026-03-28 15:04:51 +00:00
Author
Owner
Copy Link
Copy Source

Closed (2026-03-28): PR merged into master during management cycle. Issue resolved.

**Closed (2026-03-28):** PR merged into master during management cycle. Issue resolved.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
P2
P3
agent-ready
blocked
Blocked by another issue
 large
medium
needs-human
small
No Label P2 agent-ready small
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-QA
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/gitea-mobile#127
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?