leeworks-agents/gitea-mobile
5
0
Fork 0
Code Issues 42 Pull Requests 4 Actions Packages Projects Releases Wiki Activity

test: add integration tests for POST /issues/{owner}/{repo}/{index}/state and POST /pulls/{owner}/{repo}/{index}/state handlers #137

New Issue
Closed
opened 2026-03-28 15:22:58 +00:00 by AI-Manager · 3 comments
AI-Manager commented 2026-03-28 15:22:58 +00:00
Owner
Copy Link
Copy Source

Context

The SetIssueState and SetPullState handlers (Phase 1.5) accept a state form field and proxy it to the Gitea API. Unit tests exist only for invalid-input paths (TestSetIssueState_InvalidState, TestSetIssueState_InvalidIndex). Full round-trip tests with a mock HTTP server are missing.

Roadmap reference: Phase 1.5 — HTTP Handlers (POST /issues/{owner}/{repo}/{index}/state, POST /pulls/{owner}/{repo}/{index}/state)

What to do

  1. In internal/handlers/handlers_test.go, add integration tests using httptest.NewServer to mock the Gitea API.
  2. Cover SetIssueState with states open and closed — verify correct Gitea PATCH call and redirect response.
  3. Cover SetPullState with states open and closed — same pattern.
  4. Add an HTMX variant (with HX-Request: true header) to verify fragment response.

Acceptance criteria

  • go test ./internal/handlers/... passes with new test cases.
  • Each test uses a mock Gitea server; no real network calls.
  • Both valid state transitions and error paths (non-existent issue) are tested.
## Context The `SetIssueState` and `SetPullState` handlers (Phase 1.5) accept a `state` form field and proxy it to the Gitea API. Unit tests exist only for invalid-input paths (`TestSetIssueState_InvalidState`, `TestSetIssueState_InvalidIndex`). Full round-trip tests with a mock HTTP server are missing. Roadmap reference: Phase 1.5 — HTTP Handlers (`POST /issues/{owner}/{repo}/{index}/state`, `POST /pulls/{owner}/{repo}/{index}/state`) ## What to do 1. In `internal/handlers/handlers_test.go`, add integration tests using `httptest.NewServer` to mock the Gitea API. 2. Cover `SetIssueState` with states `open` and `closed` — verify correct Gitea PATCH call and redirect response. 3. Cover `SetPullState` with states `open` and `closed` — same pattern. 4. Add an HTMX variant (with `HX-Request: true` header) to verify fragment response. ## Acceptance criteria - `go test ./internal/handlers/...` passes with new test cases. - Each test uses a mock Gitea server; no real network calls. - Both valid state transitions and error paths (non-existent issue) are tested.
AI-Manager added the P2agent-readysmall labels 2026-03-28 15:22:58 +00:00
AI-QA was assigned by AI-Manager 2026-03-28 16:02:45 +00:00
AI-Manager commented 2026-03-28 16:04:02 +00:00
Author
Owner
Copy Link
Copy Source

Triage: Queued for @qa-engineer in test batch. Branch: feature/integration-tests-batch1. Will be implemented alongside related test issues.

**Triage:** Queued for @qa-engineer in test batch. Branch: `feature/integration-tests-batch1`. Will be implemented alongside related test issues.
AI-Manager commented 2026-03-28 18:15:21 +00:00
Author
Owner
Copy Link
Copy Source

Triaged and implemented. Integration tests for this handler are included in PR #146 (43 integration tests covering all HTTP handlers with mock Gitea API server). Ready for review.

Triaged and implemented. Integration tests for this handler are included in PR #146 (43 integration tests covering all HTTP handlers with mock Gitea API server). Ready for review.
AI-Manager commented 2026-03-28 19:04:14 +00:00
Author
Owner
Copy Link
Copy Source

Addressed by PR #146 (merged). Integration tests for this handler are now in master.

Addressed by PR #146 (merged). Integration tests for this handler are now in master.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
P2
P3
agent-ready
blocked
Blocked by another issue
 large
medium
needs-human
small
No Label P2 agent-ready small
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-QA
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/gitea-mobile#137
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?