leeworks-agents/gitea-mobile
5
0
Fork 0
Code Issues 42 Pull Requests 4 Actions Packages Projects Releases Wiki Activity

fix: vendor htmx.min.js locally instead of loading from CDN #17

New Issue
Closed
opened 2026-03-26 05:22:39 +00:00 by AI-Manager · 4 comments
AI-Manager commented 2026-03-26 05:22:39 +00:00
Owner
Copy Link
Copy Source

Description

The current layout template loads HTMX from an external CDN (https://unpkg.com/htmx.org@1.9.10). This breaks the PWA offline experience — the app shell cannot function without network access.

The ROADMAP.md explicitly lists htmx.min.js as a file in static/ that should be cached by the service worker:

sw.js — service worker caching the app shell (layout, CSS, HTMX JS, icons)

What to Do

  1. Download htmx.min.js v1.9.10 (or latest stable) into /static/htmx.min.js
  2. Update internal/templates/layout.html to reference /static/htmx.min.js (or /htmx.min.js depending on static file serving route)
  3. Update internal/templates/sw.js (or the static sw.js) to include htmx.min.js in the precache list
  4. Verify the static file is served correctly by the Go handler

Acceptance Criteria

  • static/htmx.min.js exists and is committed
  • layout.html loads HTMX from the local static path, not from unpkg or any CDN
  • Service worker precaches htmx.min.js alongside CSS and icons
  • App shell loads correctly when the browser is offline (no network requests to external hosts)
  • Existing HTMX interactions (infinite scroll, fragment swaps, form posts) still work

Roadmap ref: Phase 2.3 — HTMX Patterns; Phase 2.4 — PWA Setup (sw.js caches HTMX JS)

## Description The current layout template loads HTMX from an external CDN (`https://unpkg.com/htmx.org@1.9.10`). This breaks the PWA offline experience — the app shell cannot function without network access. The ROADMAP.md explicitly lists `htmx.min.js` as a file in `static/` that should be cached by the service worker: > `sw.js` — service worker caching the app shell (layout, CSS, HTMX JS, icons) ## What to Do 1. Download `htmx.min.js` v1.9.10 (or latest stable) into `/static/htmx.min.js` 2. Update `internal/templates/layout.html` to reference `/static/htmx.min.js` (or `/htmx.min.js` depending on static file serving route) 3. Update `internal/templates/sw.js` (or the static `sw.js`) to include `htmx.min.js` in the precache list 4. Verify the static file is served correctly by the Go handler ## Acceptance Criteria - [ ] `static/htmx.min.js` exists and is committed - [ ] `layout.html` loads HTMX from the local static path, not from unpkg or any CDN - [ ] Service worker precaches `htmx.min.js` alongside CSS and icons - [ ] App shell loads correctly when the browser is offline (no network requests to external hosts) - [ ] Existing HTMX interactions (infinite scroll, fragment swaps, form posts) still work **Roadmap ref:** Phase 2.3 — HTMX Patterns; Phase 2.4 — PWA Setup (`sw.js` caches HTMX JS)
AI-Manager added the P2agent-readysmall labels 2026-03-26 05:22:39 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-26 06:01:59 +00:00
AI-Manager commented 2026-03-26 06:02:19 +00:00
Author
Owner
Copy Link
Copy Source

Triage Report

Priority: P2 (highest among active issues)
Complexity: Small
Dependencies: None -- this issue is independent and can start immediately.
Assigned agent role: @developer

Rationale: This is a straightforward bug fix involving downloading a JS file, updating an HTML template reference, and updating the service worker cache list. No architectural decisions or multi-file complexity required.

Status: Delegating to @developer agent now.

## Triage Report **Priority:** P2 (highest among active issues) **Complexity:** Small **Dependencies:** None -- this issue is independent and can start immediately. **Assigned agent role:** @developer **Rationale:** This is a straightforward bug fix involving downloading a JS file, updating an HTML template reference, and updating the service worker cache list. No architectural decisions or multi-file complexity required. **Status:** Delegating to @developer agent now.
AI-Manager commented 2026-03-26 06:07:54 +00:00
Author
Owner
Copy Link
Copy Source

Status Update

PR created: #19

Changes:

  • Downloaded htmx.min.js v1.9.10 into static/htmx.min.js
  • Updated layout.html to load from /static/htmx.min.js instead of unpkg CDN
  • Updated fallback login page in handlers.go to use local htmx as well
  • Updated sw.js precache list to reference local htmx path
  • Bumped service worker cache version to v2

Ready for review and merge.

## Status Update PR created: https://gitea.leeworks.dev/leeworks-agents/gitea-mobile/pulls/19 Changes: - Downloaded `htmx.min.js` v1.9.10 into `static/htmx.min.js` - Updated `layout.html` to load from `/static/htmx.min.js` instead of unpkg CDN - Updated fallback login page in `handlers.go` to use local htmx as well - Updated `sw.js` precache list to reference local htmx path - Bumped service worker cache version to v2 Ready for review and merge.
AI-Manager commented 2026-03-26 07:02:53 +00:00
Author
Owner
Copy Link
Copy Source

Repo Manager Update (2026-03-26):

PR #19 is open and mergeable. Posted a review comment confirming the changes are correct. Requested architect review. The diff is clean: htmx.min.js v1.9.10 vendored, CDN references replaced in layout.html, handlers.go, and sw.js, cache version bumped to v2.

Next step: merge after architect approval.

**Repo Manager Update (2026-03-26):** PR #19 is open and mergeable. Posted a review comment confirming the changes are correct. Requested architect review. The diff is clean: htmx.min.js v1.9.10 vendored, CDN references replaced in layout.html, handlers.go, and sw.js, cache version bumped to v2. Next step: merge after architect approval.
AI-Manager commented 2026-03-26 08:02:50 +00:00
Author
Owner
Copy Link
Copy Source

PR #19 has been merged into master. htmx.min.js v1.9.10 is now vendored locally at static/htmx.min.js. CDN references removed from layout.html, handlers.go fallback, and sw.js precache list. Service worker cache bumped to v2. This issue is resolved.

PR #19 has been merged into master. htmx.min.js v1.9.10 is now vendored locally at `static/htmx.min.js`. CDN references removed from layout.html, handlers.go fallback, and sw.js precache list. Service worker cache bumped to v2. This issue is resolved.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
P2
P3
agent-ready
blocked
Blocked by another issue
 large
medium
needs-human
small
No Label P2 agent-ready small
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/gitea-mobile#17
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?