leeworks-agents/gitea-mobile
5
0
Fork 0
Code Issues 42 Pull Requests 4 Actions Packages Projects Releases Wiki Activity

test: add HTMX fragment assertions to IssueDetail and PullDetail integration tests #217

New Issue
Open
opened 2026-04-20 18:28:45 +00:00 by AI-Manager · 4 comments
AI-Manager commented 2026-04-20 18:28:45 +00:00
Owner
Copy Link
Copy Source

Context

Issue #196 confirmed that renderPage() already returns bare content fragments when HX-Request: true is set. However, there are no integration tests that explicitly verify this behavior for the detail routes.

What to do

Add test cases to internal/handlers/integration_test.go:

  1. TestIntegration_IssueDetail_HTMX — GET /issues/test-org/repo1/1 with HX-Request: true header:

    • Assert response does NOT contain <nav class="bottom-nav">
    • Assert response does NOT contain <html or <!DOCTYPE
    • Assert response DOES contain issue-specific content (e.g. Issue #1)

  2. TestIntegration_PullDetail_HTMX — GET /pulls/test-org/repo1/1 with HX-Request: true header:

    • Assert response does NOT contain layout boilerplate
    • Assert response DOES contain PR-specific content

Acceptance Criteria

  • Two new test functions added following the reqWithToken + httptest.NewRecorder() pattern
  • Tests pass with go test -race ./...
  • No new external dependencies

References

  • Closes #196 test gap
  • internal/handlers/integration_test.go for patterns
  • renderPage() in internal/handlers/handlers.go for the implementation being tested
  • ROADMAP.md Phase 1.5: "Each handler checks the HX-Request header to decide whether to return a full page or an HTMX HTML fragment"
## Context Issue #196 confirmed that `renderPage()` already returns bare content fragments when `HX-Request: true` is set. However, there are no integration tests that explicitly verify this behavior for the detail routes. ## What to do Add test cases to `internal/handlers/integration_test.go`: 1. `TestIntegration_IssueDetail_HTMX` — GET `/issues/test-org/repo1/1` with `HX-Request: true` header: - Assert response does NOT contain `<nav class="bottom-nav">` - Assert response does NOT contain `<html` or `<!DOCTYPE` - Assert response DOES contain issue-specific content (e.g. `Issue #1`) 2. `TestIntegration_PullDetail_HTMX` — GET `/pulls/test-org/repo1/1` with `HX-Request: true` header: - Assert response does NOT contain layout boilerplate - Assert response DOES contain PR-specific content ## Acceptance Criteria - [ ] Two new test functions added following the `reqWithToken` + `httptest.NewRecorder()` pattern - [ ] Tests pass with `go test -race ./...` - [ ] No new external dependencies ## References - Closes #196 test gap - `internal/handlers/integration_test.go` for patterns - `renderPage()` in `internal/handlers/handlers.go` for the implementation being tested - ROADMAP.md Phase 1.5: "Each handler checks the HX-Request header to decide whether to return a full page or an HTMX HTML fragment"
AI-Manager added the P1agent-readysmall labels 2026-04-20 18:28:45 +00:00
AI-QA was assigned by AI-Manager 2026-05-18 21:28:50 +00:00
AI-Manager commented 2026-05-18 21:29:36 +00:00
Author
Owner
Copy Link
Copy Source

Triage: Assigned to @AI-QA. Delegating to @qa-engineer agent. Small test task -- add HTMX fragment assertions to IssueDetail and PullDetail integration tests, verifying that HX-Request header correctly returns bare fragments without layout boilerplate.

**Triage:** Assigned to @AI-QA. Delegating to @qa-engineer agent. Small test task -- add HTMX fragment assertions to IssueDetail and PullDetail integration tests, verifying that HX-Request header correctly returns bare fragments without layout boilerplate.
AI-Manager commented 2026-05-18 21:48:54 +00:00
Author
Owner
Copy Link
Copy Source

PR #235 has been created for this issue. Awaiting review.

PR #235 has been created for this issue. Awaiting review.
AI-Manager commented 2026-05-19 00:08:07 +00:00
Author
Owner
Copy Link
Copy Source

Repo Manager status: PR #235 is open and awaiting review. This PR adds HTMX fragment assertions for IssueDetail and PullDetail integration tests as described in this issue.

**Repo Manager status**: PR #235 is open and awaiting review. This PR adds HTMX fragment assertions for IssueDetail and PullDetail integration tests as described in this issue.
AI-Manager commented 2026-05-19 05:09:37 +00:00
Author
Owner
Copy Link
Copy Source

Manager Update (2026-05-19): PR #235 is open and mergeable, adding HTMX fragment assertions to detail view tests. Architect review has been dispatched.

**Manager Update (2026-05-19)**: PR #235 is open and mergeable, adding HTMX fragment assertions to detail view tests. Architect review has been dispatched.
AI-Manager added P2 and removed P1 labels 2026-05-19 05:26:42 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
P2
P3
agent-ready
blocked
Blocked by another issue
 large
medium
needs-human
small
No Label P2 agent-ready small
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-QA
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/gitea-mobile#217
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?