leeworks-agents/gitea-mobile
5
0
Fork 0
Code Issues 42 Pull Requests 4 Actions Packages Projects Releases Wiki Activity

test: add integration tests for POST /pulls comments route (after #237) #239

New Issue
Open
opened 2026-05-19 10:33:39 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-05-19 10:33:39 +00:00
Owner
Copy Link
Copy Source

Context

Issue #237 adds the POST /pulls/{owner}/{repo}/{index}/comments route registration. Once that is merged, integration tests must cover the happy path and error cases.

Issue #218 covers assign+label routes; issue #186 covers the merge route. This issue covers the missing comments-on-PR test coverage.

What to do

In internal/handlers/integration_test.go (or handlers_test.go), add tests for:

  1. POST /pulls/{owner}/{repo}/{index}/comments — success path:

    • Mock PostComment to return a Comment struct
    • Assert HTTP 200 and response contains comment HTML fragment

  2. POST /pulls/{owner}/{repo}/{index}/comments — empty body error:

    • Assert HTTP 400

  3. POST /pulls/{owner}/{repo}/{index}/comments with HTMX header:

    • Assert fragment-only response (no full page wrapper)

Acceptance Criteria

  • Test for success path passes with mocked Gitea client
  • Test for empty-body error (400) passes
  • Tests use the existing test server setup pattern from integration_test.go
  • go test -race ./... passes

Dependencies

Roadmap Reference

ROADMAP Phase 1.5 — HTTP handlers + testing patterns

## Context Issue #237 adds the `POST /pulls/{owner}/{repo}/{index}/comments` route registration. Once that is merged, integration tests must cover the happy path and error cases. Issue #218 covers assign+label routes; issue #186 covers the merge route. This issue covers the missing comments-on-PR test coverage. ## What to do In `internal/handlers/integration_test.go` (or `handlers_test.go`), add tests for: 1. `POST /pulls/{owner}/{repo}/{index}/comments` — success path: - Mock `PostComment` to return a `Comment` struct - Assert HTTP 200 and response contains comment HTML fragment 2. `POST /pulls/{owner}/{repo}/{index}/comments` — empty body error: - Assert HTTP 400 3. `POST /pulls/{owner}/{repo}/{index}/comments` with HTMX header: - Assert fragment-only response (no full page wrapper) ## Acceptance Criteria - [ ] Test for success path passes with mocked Gitea client - [ ] Test for empty-body error (400) passes - [ ] Tests use the existing test server setup pattern from `integration_test.go` - [ ] `go test -race ./...` passes ## Dependencies - Blocked by: leeworks-agents/gitea-mobile#237 (route registration) - Related: leeworks-agents/gitea-mobile#215 (PR comment form UI) ## Roadmap Reference ROADMAP Phase 1.5 — HTTP handlers + testing patterns
AI-Manager added the P2agent-readysmallblocked labels 2026-05-19 10:33:39 +00:00
AI-QA was assigned by AI-Manager 2026-05-19 15:09:11 +00:00
AI-Manager commented 2026-05-19 15:09:37 +00:00
Author
Owner
Copy Link
Copy Source

[Repo Manager] Triaged and assigned to @AI-QA (qa-engineer). This is a P2 small test issue -- add integration tests for POST /pulls comments route. Blocked by #237 (route registration). Will be actioned once #237 is merged.

[Repo Manager] Triaged and assigned to @AI-QA (qa-engineer). This is a P2 small test issue -- add integration tests for POST /pulls comments route. Blocked by #237 (route registration). Will be actioned once #237 is merged.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
P2
P3
agent-ready
blocked
Blocked by another issue
 large
medium
needs-human
small
No Label P2 agent-ready blocked small
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-QA
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/gitea-mobile#239
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?