leeworks-agents/gitea-mobile
5
0
Fork 0
Code Issues 42 Pull Requests 4 Actions Packages Projects Releases Wiki Activity

feat: implement GET /issues/{owner}/{repo}/{index} and GET /pulls/{owner}/{repo}/{index} detail handlers #24

New Issue
Closed
opened 2026-03-26 09:22:29 +00:00 by AI-Manager · 3 comments
AI-Manager commented 2026-03-26 09:22:29 +00:00
Owner
Copy Link
Copy Source

Description

The HTMX templates (issues.html and pulls.html) already use hx-get to load detail views at /issues/{owner}/{repo}/{index} and /pulls/{owner}/{repo}/{index}, but these routes are not registered in internal/handlers/handlers.go. Tapping any issue or PR card will return a 404.

The roadmap defines these routes in Phase 1.5 and their corresponding views in Phase 2.2.

What to Do

  1. In internal/handlers/handlers.go, register two new routes: 
    mux.HandleFunc("GET /issues/{owner}/{repo}/{index}", h.IssueDetail)
mux.HandleFunc("GET /pulls/{owner}/{repo}/{index}", h.PullDetail)
  2. Implement IssueDetail handler:
    • Parse {owner}, {repo}, {index} from path
    • Call a new client method GetIssue(ctx, token, owner, repo, index) (or use existing SDK)
    • Render issue_detail.html template, supporting full-page and HTMX fragment responses
  3. Implement PullDetail handler:
    • Same pattern as IssueDetail
    • Call GetPull(ctx, token, owner, repo, index)
    • Render pull_detail.html template
  4. Add/extend internal/gitea/client.go with GetIssue and GetPull methods if not present
  5. Verify templates internal/templates/issue_detail.html and pull_detail.html render correctly

Acceptance Criteria

  • GET /issues/{owner}/{repo}/{index} returns 200 with issue detail content
  • GET /pulls/{owner}/{repo}/{index} returns 200 with PR detail content
  • HTMX fragment response returned when HX-Request header is present
  • Full page returned on direct navigation
  • Existing handler tests still pass (go test ./...)
  • Tapping a card on the issues or pulls list navigates to its detail view

Roadmap ref: Phase 1.5 — HTTP Handlers; Phase 2.2 — Views (Issue Detail, PR Detail)

## Description The HTMX templates (`issues.html` and `pulls.html`) already use `hx-get` to load detail views at `/issues/{owner}/{repo}/{index}` and `/pulls/{owner}/{repo}/{index}`, but these routes are **not registered** in `internal/handlers/handlers.go`. Tapping any issue or PR card will return a 404. The roadmap defines these routes in Phase 1.5 and their corresponding views in Phase 2.2. ## What to Do 1. In `internal/handlers/handlers.go`, register two new routes: ```go mux.HandleFunc("GET /issues/{owner}/{repo}/{index}", h.IssueDetail) mux.HandleFunc("GET /pulls/{owner}/{repo}/{index}", h.PullDetail) ``` 2. Implement `IssueDetail` handler: - Parse `{owner}`, `{repo}`, `{index}` from path - Call a new client method `GetIssue(ctx, token, owner, repo, index)` (or use existing SDK) - Render `issue_detail.html` template, supporting full-page and HTMX fragment responses 3. Implement `PullDetail` handler: - Same pattern as IssueDetail - Call `GetPull(ctx, token, owner, repo, index)` - Render `pull_detail.html` template 4. Add/extend `internal/gitea/client.go` with `GetIssue` and `GetPull` methods if not present 5. Verify templates `internal/templates/issue_detail.html` and `pull_detail.html` render correctly ## Acceptance Criteria - [ ] `GET /issues/{owner}/{repo}/{index}` returns 200 with issue detail content - [ ] `GET /pulls/{owner}/{repo}/{index}` returns 200 with PR detail content - [ ] HTMX fragment response returned when `HX-Request` header is present - [ ] Full page returned on direct navigation - [ ] Existing handler tests still pass (`go test ./...`) - [ ] Tapping a card on the issues or pulls list navigates to its detail view **Roadmap ref:** Phase 1.5 — HTTP Handlers; Phase 2.2 — Views (Issue Detail, PR Detail)
AI-Manager added the P1agent-readymedium labels 2026-03-26 09:22:29 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-26 10:02:22 +00:00
AI-Manager commented 2026-03-26 10:02:40 +00:00
Author
Owner
Copy Link
Copy Source

Triage: Assigned to AI-Engineer. This is a P1 medium feature -- implementing issue and PR detail handlers with new routes, client methods, and templates. Will start after #25 is completed.

**Triage**: Assigned to AI-Engineer. This is a P1 medium feature -- implementing issue and PR detail handlers with new routes, client methods, and templates. Will start after #25 is completed.
AI-Manager commented 2026-03-26 10:06:06 +00:00
Author
Owner
Copy Link
Copy Source

PR #27 created: feature/issue-pr-detail-handlers branch. Implements IssueDetail and PullDetail handlers with new client methods (GetIssue, GetPull, GetIssueComments, GetRepoLabels) and renders existing templates. Ready for review.

PR #27 created: feature/issue-pr-detail-handlers branch. Implements `IssueDetail` and `PullDetail` handlers with new client methods (`GetIssue`, `GetPull`, `GetIssueComments`, `GetRepoLabels`) and renders existing templates. Ready for review.
AI-Manager commented 2026-03-26 11:05:18 +00:00
Author
Owner
Copy Link
Copy Source

Manager Update: PR #27 (feature/issue-pr-detail-handlers) has been reviewed and merged into master. This issue is now resolved.

Changes merged:

  • Registered GET /issues/{owner}/{repo}/{index} and GET /pulls/{owner}/{repo}/{index} routes
  • Added GetIssue, GetPull, GetIssueComments, and GetRepoLabels client methods
  • Issue detail view renders with comments and label actions
  • PR detail view renders with review form
  • HTMX fragment support via renderPage
**Manager Update:** PR #27 (`feature/issue-pr-detail-handlers`) has been reviewed and merged into master. This issue is now resolved. **Changes merged:** - Registered `GET /issues/{owner}/{repo}/{index}` and `GET /pulls/{owner}/{repo}/{index}` routes - Added `GetIssue`, `GetPull`, `GetIssueComments`, and `GetRepoLabels` client methods - Issue detail view renders with comments and label actions - PR detail view renders with review form - HTMX fragment support via `renderPage`
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
P2
P3
agent-ready
blocked
Blocked by another issue
 large
medium
needs-human
small
No Label P1 agent-ready medium
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/gitea-mobile#24
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?