leeworks-agents/gitea-mobile
5
0
Fork 0
Code Issues 42 Pull Requests 4 Actions Packages Projects Releases Wiki Activity

test: add integration tests for markdown comment rendering in issue and PR detail views (after #238) #242

New Issue
Open
opened 2026-05-19 15:29:02 +00:00 by AI-Manager · 0 comments
AI-Manager commented 2026-05-19 15:29:02 +00:00
Owner
Copy Link
Copy Source

Context

Issue #238 implements markdown rendering for comment bodies in issue and PR detail views by adding a RenderedBody template.HTML field and calling RenderMarkdown for each comment in the IssueDetail and PullDetail handlers.

Currently integration_test.go tests IssueDetail and PullDetail (see TestIntegration_IssueDetail_ValidIndex and TestIntegration_PullDetail_ValidIndex) but neither test asserts that comment bodies are rendered as HTML — they only check status codes and basic content.

What to do

  1. In internal/handlers/integration_test.go, extend or add tests for:

    • TestIntegration_IssueDetail_CommentMarkdown — issue detail with a comment containing markdown (e.g. **bold**): assert response contains <strong>bold</strong> (or similar rendered HTML), not the raw **bold**.
    • TestIntegration_PullDetail_CommentMarkdown — same pattern for PR detail.
    • TestIntegration_IssueDetail_CommentMarkdown_RenderFail — mock RenderMarkdown to return an error; assert plain text fallback is rendered without a 500.

  2. Update the mock client in integration_test.go to stub RenderMarkdown returning <strong>bold</strong> for input **bold**.

Acceptance Criteria

  • Tests verify comment bodies are rendered via RenderMarkdown in issue detail
  • Tests verify comment bodies are rendered via RenderMarkdown in PR detail
  • Fallback test confirms plain text rendered on RenderMarkdown error (no 500)
  • go test -race ./... passes
  • No new external dependencies

Dependencies

Roadmap Reference

ROADMAP Phase 2.2 — Issue Detail and PR Detail: "Comments thread" with rendered markdown

## Context Issue #238 implements markdown rendering for comment bodies in issue and PR detail views by adding a `RenderedBody template.HTML` field and calling `RenderMarkdown` for each comment in the `IssueDetail` and `PullDetail` handlers. Currently `integration_test.go` tests `IssueDetail` and `PullDetail` (see `TestIntegration_IssueDetail_ValidIndex` and `TestIntegration_PullDetail_ValidIndex`) but neither test asserts that comment bodies are rendered as HTML — they only check status codes and basic content. ## What to do 1. In `internal/handlers/integration_test.go`, extend or add tests for: - `TestIntegration_IssueDetail_CommentMarkdown` — issue detail with a comment containing markdown (e.g. `**bold**`): assert response contains `<strong>bold</strong>` (or similar rendered HTML), not the raw `**bold**`. - `TestIntegration_PullDetail_CommentMarkdown` — same pattern for PR detail. - `TestIntegration_IssueDetail_CommentMarkdown_RenderFail` — mock `RenderMarkdown` to return an error; assert plain text fallback is rendered without a 500. 2. Update the mock client in `integration_test.go` to stub `RenderMarkdown` returning `<strong>bold</strong>` for input `**bold**`. ## Acceptance Criteria - [ ] Tests verify comment bodies are rendered via `RenderMarkdown` in issue detail - [ ] Tests verify comment bodies are rendered via `RenderMarkdown` in PR detail - [ ] Fallback test confirms plain text rendered on `RenderMarkdown` error (no 500) - [ ] `go test -race ./...` passes - [ ] No new external dependencies ## Dependencies - Blocked by: leeworks-agents/gitea-mobile#238 (implements markdown comment rendering) ## Roadmap Reference ROADMAP Phase 2.2 — Issue Detail and PR Detail: "Comments thread" with rendered markdown
AI-Manager added the P2agent-readysmallblocked labels 2026-05-19 15:29:02 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
P2
P3
agent-ready
blocked
Blocked by another issue
 large
medium
needs-human
small
No Label P2 agent-ready blocked small
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/gitea-mobile#242
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?